-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Updated How to get data
modal
#370
Conversation
Reviewer's Guide by SourceryThis PR updates the "How to get data" modal with improved UI/UX and clearer instructions. The implementation reorganizes the content layout, adds a copy button functionality for the Docker command, and enhances the explanatory text. The changes use Material-UI components and React hooks for state management. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmanaem - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the 'Changes proposed' section in the PR description to help reviewers understand the changes at a high level.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmanaem for the lovely UI changes and updated modal text. The copy button for the code snippet works great!
Looking at the preview again, I'm struck by how long the modal still is (following my suggested edits), so I've left some suggestions below to further trim and simplify the text.
Otherwise, 🧑🍳 !!
Hey @rmanaem, for the sake of re-releasing, I'm going to apply my suggested changes and merge! |
🚀 PR was released in |
how to get data
modal #367Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
query-tool-results
files in the neurobagel_examples repo have been regeneratedFor new features:
For bug fixes: