Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move vocab turtle file from api repo #15

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Feb 2, 2024

Closes #14
Closes #12

Changes proposed in this pull request:

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs
Copy link
Contributor Author

surchs commented Feb 2, 2024

for reviewer: I wonder if we should just combine this with #12 since it's very similar

@alyssadai alyssadai self-requested a review February 3, 2024 18:18
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @surchs.

Agreed about combining this with #12 (I've separated out the actual updating of the table values into a separate issue #16 to make the diffs cleaner).

I pushed the addition of the environment variables TSV directly to this branch - hope you don't mind - and renamed the TSV to be more generic.

I also requested your review on the two related issues for

  • updating the link to the TSV in the documentation repo (this PR should still be merged first)
  • removing the TSV from the api repo

Have a look, and then 🧑‍🍳

@surchs
Copy link
Contributor Author

surchs commented Feb 3, 2024

Awesome, thank you very much!

@surchs surchs merged commit 4dbcdaa into main Feb 3, 2024
@alyssadai alyssadai deleted the add_vocab_example branch February 4, 2024 04:02
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Neurobagel vocab file to local_node recipe Move environment variable table from neurobagel/api
2 participants