Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Consolidate deployment recipes and refactor template.env #46

Merged
merged 14 commits into from
Apr 22, 2024
Merged

[REF] Consolidate deployment recipes and refactor template.env #46

merged 14 commits into from
Apr 22, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Apr 21, 2024 •
edited by surchs
Loading

Changes proposed in this PR:

  • Remove deployment-specific configuration files
  • Switch to explicitly mounting subdirectories necessary for graph setup into GraphDB container
  • Update paths in compatibility test workflows

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai marked this pull request as ready for review April 21, 2024 02:36
@surchs surchs self-requested a review April 21, 2024 14:23
surchs
surchs approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai, README looks great.

I made two suggestions that I think are needed to ensure people know ahead of time how to configure this. The main goal here is to make this an easy, not frustrating experience!

Please check and then apply those (or a variant) before merging.

With that 🧑‍🍳

.github/workflows/compatibility-test copy.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
template.env Outdated Show resolved Hide resolved
alyssadai and others added 5 commits April 21, 2024 21:29
@alyssadai @surchs
More context in template.env and README
00a7d66 
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
@alyssadai
fix README spacing
0b3266c
@alyssadai
fix README spacing (again)
2d2e78d
@alyssadai
fix README spacing (again)
b787d0f
@alyssadai
update environment variable table
17d04ef 
- added new variables:
  - NB_GRAPH_ADMIN_PASSWORD
  - LOCAL_GRAPH_DATA
- split NB_API_PORT, NB_API_PORT_HOST, and NB_API_TAG into f-API and n-API
@alyssadai alyssadai merged commit 7bc5311 into main Apr 22, 2024
@alyssadai alyssadai deleted the consolidate-recipes branch April 22, 2024 02:28
@surchs surchs mentioned this pull request Apr 24, 2024
Merged
3 tasks
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deployment-specific Compose files and consolidate repo
2 participants
@alyssadai @surchs