Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add COMPOSE_PROJECT_NAME to template.env #48

Merged
merged 3 commits into from
Apr 23, 2024
Merged

[ENH] Add COMPOSE_PROJECT_NAME to template.env #48

merged 3 commits into from
Apr 23, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Apr 23, 2024 •
edited by surchs
Loading

See https://docs.docker.com/compose/project-name/

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai changed the title [ENH] Add COMPOSE_PROJECT_NAME to template.env [ENH] Add COMPOSE_PROJECT_NAME to template.env Apr 23, 2024
@alyssadai alyssadai marked this pull request as ready for review April 23, 2024 20:56
@alyssadai alyssadai requested a review from surchs April 23, 2024 20:56
surchs
surchs approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion to explain purpose first

🧑‍🍳

template.env Show resolved Hide resolved
@alyssadai @surchs
Update comment
adaa4c9 
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
@alyssadai alyssadai merged commit 29dcca7 into main Apr 23, 2024
@alyssadai alyssadai deleted the alyssadai-patch-1 branch April 23, 2024 21:12
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssadai @surchs