Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Renamed NB_QUERY_URL_PATH env var to NB_QUERY_APP_BASE_PATH #77

Merged
merged 2 commits into from
Aug 9, 2024
Merged

[MNT] Renamed NB_QUERY_URL_PATH env var to NB_QUERY_APP_BASE_PATH #77

merged 2 commits into from
Aug 9, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Aug 8, 2024 •
edited by surchs
Loading

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem changed the title [MNT] Renamed NB_QUERY_URL_PATH env var to NB_QUERY_APP_BASE_PATH [MNT] Renamed NB_QUERY_URL_PATH env var to NB_QUERY_APP_BASE_PATH Aug 8, 2024
@surchs surchs self-requested a review August 8, 2024 20:29
surchs
surchs approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, just need to resolve conflicts and then 🧑‍🍳

@rmanaem rmanaem added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Aug 9, 2024
@rmanaem rmanaem merged commit 9559390 into main Aug 9, 2024
@rmanaem rmanaem deleted the maint-74 branch August 9, 2024 16:53
@alyssadai alyssadai added pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) and removed pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) labels Aug 14, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

🚀 PR was released in v0.1.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename NB_QUERY_URL_PATH env var to NB_QUERY_APP_BASE_PATH
3 participants
@rmanaem @surchs @alyssadai