Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Updated compatibility.yaml file and e2e tests #78

Merged
merged 10 commits into from
Aug 12, 2024
Merged

[MNT] Updated compatibility.yaml file and e2e tests #78

merged 10 commits into from
Aug 12, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Aug 8, 2024 •
edited by surchs
Loading

Changes proposed in this pull request:

  • Updated e2e tests
  • Updated compatibility.yaml file
    • Added a step to modify the NB_API_QUERY_URL env var before bringing the stack up
    • Renamed the workflow from Compatibility of to Tool version compatibility test
  • Added badge for Tool version compatibility test to README.md

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs self-requested a review August 8, 2024 20:10
surchs
surchs approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🧑‍🍳

README.md Show resolved Hide resolved
@surchs
Copy link
Contributor

surchs commented Aug 9, 2024

We should also add an internal release label

@rmanaem rmanaem added the pr-tests Add or improve existing tests label Aug 9, 2024
@rmanaem
Copy link
Contributor Author

rmanaem commented Aug 9, 2024

We should also add an internal release label

Do u mean to release off of this PR?

@rmanaem rmanaem added pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) and removed pr-tests Add or improve existing tests labels Aug 12, 2024
@rmanaem rmanaem merged commit dadcbc6 into main Aug 12, 2024
@rmanaem rmanaem deleted the test-e2e branch August 12, 2024 16:02
@alyssadai alyssadai mentioned this pull request Aug 14, 2024
Merged
7 tasks
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

🚀 PR was released in v0.1.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmanaem @surchs