Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

style-loader: allChunks: true for ExtractTextPlugin? #503

Closed
timkelty opened this issue Dec 1, 2017 · 2 comments
Closed

style-loader: allChunks: true for ExtractTextPlugin? #503

timkelty opened this issue Dec 1, 2017 · 2 comments

Comments

@timkelty
Copy link
Contributor

timkelty commented Dec 1, 2017

I'm wondering if we should be setting allChunks: true for ExtractTextPlugin in style-loader: https://github.com/webpack-contrib/extract-text-webpack-plugin#options

Does anybody have experience with this option? Reading the description, I'm still not 💯 I grasp if and when to use it, but it does mention combined use with CommonsChunkPlugin:

Extract from all additional chunks too (by default it extracts only from the initial chunk(s))
When using CommonsChunkPlugin and there are extracted chunks (from ExtractTextPlugin.extract) in the commons chunk, allChunks must be set to true

Any ideas @mozilla-neutrino/core-contributors?

@eliperelman
Copy link
Member

From reading the description it seems like we should be setting it to true when using with extract.

@timkelty
Copy link
Contributor Author

timkelty commented Dec 1, 2017

@eliperelman that was my impression as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants