Add vue preset #457

helfi92 · 2017-11-19T17:04:42Z

No description provided.

helfi92 · 2017-11-19T17:05:59Z

The first commit is the original code of the exported preset. I will send patches to this pull-request.

…trinojs#452) * Scaffold new projects with a CLI helper (neutrinojs#376) * Scaffold new projects with a CLI helper * Implement requested changes * Change initial syntax command to be `create-neutrino-project <directory>` * Remove vorpal in favor of yargs * Look at `process.env.npm_config_user_agent` to see if user is using yarn * Remove author&description from questions. Do (yarn|npm) init instead * Take most recent version of package instead of hardcoding it * Use javascript-stringify instead of JSON.stringify * Nits * Add success message * Round 2 changes * Round 3 + Add neutrino lint --fix * Put all methods inside the Generator class * Change one instance of let to const * Nits addressed * Switch template string to normal string * Scaffold a new project documentation (neutrinojs#416) * Scaffold a new project docs * Add requested changes * Use more compact markdown tables Use more compact tables to stay consistent with the reset of the docs. * Better terminal output when using the scaffolding app (neutrinojs#448) * Add Preact to the scaffolding app (neutrinojs#447) * Add Vue to the scaffolding app (neutrinojs#450) * Add Vue to the scaffolding app * Add blank line and change indentation to 2 spaces * Make create CLI fall in line with scoped package names * Add ascii logo banner to create-cli, make speech more friendly

* Easier browser targeting via options.browsers * Pass targets instead of browsers, to both web and node * Update docs * Update docs for node, web * Fix presetEnv reference in docs.

* Add official airbnb preset * Add eslintrc to validation

…eutrinojs#453)

…trinojs#461) This reverts commit c57de40.

eliperelman · 2017-11-21T03:47:57Z

packages/vue/README.md

+If you wish to copy files to the build directory that are not imported from application code, you can place
+them in a directory within `src` called `static`. All files in this directory will be copied from `src/static`
+to `build/static`. To change this behavior, specify your own patterns with
+[@neutrinojs/copy](../../packages/copy/README.md).


This should be an absolute URL when in the package README.

eliperelman

Also remove the yarn.lock file in the package dir.

eliperelman · 2017-11-21T03:48:48Z

packages/vue/README.md

+        // Override options for babel-preset-env
+        presets: [
+          ['babel-preset-env', {
+            // Passing in targets to babel-preset-env will replace them


This has been moved to options.targets. See the web preset for updated docs.

eliperelman · 2017-11-21T03:51:16Z

packages/vue/package.json

+  "license": "GPL-3.0",
+  "peerDependencies": {
+    "neutrino": "^7.0.0",
+    "vue": "^2.5.0"


Remove the vue peerDependency. If we need it during development testing, we can discuss.

eliperelman · 2017-11-21T03:51:32Z

packages/vue/package.json

+    "vue": "^2.5.0"
+  },
+  "devDependencies": {
+    "eslint": "^4.9.0",


What are these devDependencies for?

eliperelman · 2017-11-21T03:59:06Z

packages/vue/src/index.js

+
+  if (lintRule) {
+    // ensure conditions is an array of original values plus our own regex
+    const conditions = arrify(lintRule.get('test')).concat([LOADER_EXTENSIONS]);


Maybe instead of this, we go back and update all our regexes to include vue (and maybe ts as well):

test(/\.(js,jsx,vue,ts)$/)

We could also introduce another API option: extensions.

neutrino.options.extensions = new Set([ 'js', 'jsx' 'vue' 'ts', 'mjs' ]);

Then we could iterate valid extensions in other places. Thoughts?

eliperelman · 2017-11-21T04:01:08Z

packages/vue/src/index.js

+
+  if (neutrino.config.plugins.has('stylelint')) {
+    neutrino.config.plugin('stylelint')
+      .tap(args => [


This seems like it ignores all other arguments. If there aren't any, we can be explicit about extending the first arg using destructuring, otherwise we could spread the rest of the args:

.tap(([options, ...args]) => [ merge(options, { ... }), ...args ]);

eliperelman · 2017-11-21T04:07:57Z

packages/vue/src/index.js

+    .loader(require.resolve('vue-loader'))
+    .options(options);
+
+  if (compileRule && compileRule.uses.has('babel')) {


I'm confused about what this does. These isn't a compile loader here until neutrino.use(web, options).

eliperelman · 2017-11-21T04:10:38Z

packages/vue/package.json

+  "description": "Neutrino preset adding Vue.js support.",
+  "main": "src/index.js",
+  "author": "Capi Etheriel <barraponto@gmail.com> (https://barraponto.blog.br)",
+  "license": "GPL-3.0",


In order for us to use the code as-is from the original repo, we need to re-license this new version as MPL-2.0. @barraponto do we have your permission for that?

…ork middleware (neutrinojs#425) * Support building multiple configurations from a single project with fork middleware * Add fork middleware documentation * Have eslintrc consume neutrinorc middleware

…no-dev (neutrinojs#432) * Initial commit * Create README.md * Update README.md * Updating README * Switch to react preset for base instead of node * Swapping storybook-ui for simpler custom solution * v1.0.0 prep * Feature: optimizing bundles * v1.1.0 * v1.1.1 - removing babel-polyfill * Switching to fast-async, removing regenerator * Adding missing fast-async * Fixing switching stories * v1.2.2 * Upgrading to neutrino v6 * Fixing react classes with HMR, upgrading deps * hints 'error' instead of true * 2.1.1 * 2.1.2 * Unmerged commit * 2.1.3 * Upgrading to Neutrino v7 * 3.0.0 * Initial implementation of importing react-components preset to neutrino-dev

* Set name defaults for file/url-loader * Fix option short circuit

…utrinojs#455) * Add official preact preset to packages (neutrinojs#454) * Update preact preset to fall in line with scoped packages * Convert preact preset to latest Neutrino API * Automatically import createElement from react to match preact behavior * Update docs for preact preset to more closely follow react+web targets

…ojs#462)

* Conditionally include loaders, preset * Use options.html * Type juggle options.devServer.proxy instead of options.devServerProxy * Set defaults based on options.html * Add Manifest * Clean output always * Code style * html-loader is unrelated to html generation, include it. * Use `/` for publicPath * Simplify publicPath * Resolve devServer.publicPath to a root relative url * Keep previous default * Use single `html` option * Only clean on build * fix(deps): update dependency ramda to ^0.25.0 (neutrinojs#405) * fix(deps): update dependency file-loader to v^1.0.0 (neutrinojs#397) * Ignore gitbook-plugin-github from automatic renovate (neutrinojs#444)

…false to exclude. (neutrinojs#465)

…s#479)

* Add font, image options. * Expanded docs for web.

Turn the migration guide into a page that covers all versions

…inojs#481)

…inojs#480)

helfi92 · 2017-11-22T14:40:11Z

Closing. Will continue in #484.

helfi92 self-assigned this Nov 19, 2017

helfi92 changed the title ~~Add untouched barraponto vue preset.~~ Add vue preset Nov 20, 2017

eliperelman and others added 7 commits November 20, 2017 14:43

web/node: Easier targeting via options.targets (neutrinojs#438)

caf065c

* Easier browser targeting via options.browsers * Pass targets instead of browsers, to both web and node * Update docs * Update docs for node, web * Fix presetEnv reference in docs.

Add official airbnb preset (neutrinojs#436)

df14b90

* Add official airbnb preset * Add eslintrc to validation

Regression: allow defining neutrinorc as directory (neutrinojs#426)

7f7265b

Introduce official standardjs preset for consumption by create CLI (n…

076f6d4

…eutrinojs#453)

Add optimize option, use in web, node. (neutrinojs#460)

c57de40

Revert "Add optimize option, use in web, node. (neutrinojs#460)" (neu…

6c58ede

…trinojs#461) This reverts commit c57de40.

eliperelman reviewed Nov 21, 2017

View reviewed changes

eliperelman suggested changes Nov 21, 2017

View reviewed changes

eliperelman reviewed Nov 21, 2017

View reviewed changes

eliperelman and others added 17 commits November 20, 2017 22:13

Support building multiple configurations from a single project with f…

cc1a22a

…ork middleware (neutrinojs#425) * Support building multiple configurations from a single project with fork middleware * Add fork middleware documentation * Have eslintrc consume neutrinorc middleware

Initial implementation of generic library middleware (neutrinojs#431)

40d14b9

Set name defaults for file/url-loader (neutrinojs#435)

d680010

* Set name defaults for file/url-loader * Fix option short circuit

fix(deps): update dependency deepmerge to ^2.0.0 (neutrinojs#401)

9f90d02

fix(deps): update dependency mocha to ^4.0.0 (neutrinojs#463)

b8386e4

fix(deps): update dependency style-loader to ^0.19.0 (neutrinojs#406)

bdabbe4

fix(deps): update dependency url-loader to ^0.6.0 (neutrinojs#407)

03feb19

fix(deps): update dependency html-webpack-template to ^6.1.0 (neutrin…

810a1e8

…ojs#462)

Expose minify and manifest options for the web preset, allow passing …

dfd3791

…false to exclude. (neutrinojs#465)

Update all outdated dependencies for v8 (neutrinojs#464)

7047a0d

Update to utilize ChromeHeadless as browser in preset-karma

6191d6f

Update karma docs for usage on Chrome headless and normal browser in CI

1f2d8dc

Merge branch 'jaridmargolin-karma-chromeheadless'

5a7d8c7

Fix library package nesting (neutrinojs#474)

5c288bb

helfi92 and others added 19 commits November 21, 2017 12:50

Turn the migration guide into a page that covers all versions

ce4e4e5

Revise docs to sync updates to linting documentation (neutrinojs#477)

1c39203

Web: Clean up option merging, better default for manifest. (neutrinoj…

3dfd20c

…s#479)

Add font, image options. (neutrinojs#467)

641e846

* Add font, image options. * Expanded docs for web.

Merge pull request neutrinojs#478 from helfi92/migration-docs

6e0b8f3

Turn the migration guide into a page that covers all versions

Roll back deepmerge due to breakage in plugin argument merging (neutr…

53a9ec9

…inojs#481)

Add JSX rules to standard preset for use in jsx-based projects (neutr…

cfe4a9f

…inojs#480)

Add yarn script helper for linking all packages (neutrinojs#476)

f934263

Remove orphaned deepmerge lock entry

1bcb6e2

Add untouched barraponto vue preset.

2504d48

Add web preset

e1a5839

Update name and package version

71e5fef

Remove PostCSS

09f533a

Nit

ccef81b

Update package version

1319326

Update vue documentation

0713564

Remove unnecessary items in package.json

903894c

Update README

691214e

Use the web preset before everything

f8828b4

helfi92 force-pushed the vue-temporary branch from 570e765 to f8828b4 Compare November 22, 2017 03:58

helfi92 closed this Nov 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add vue preset #457

Add vue preset #457

helfi92 commented Nov 19, 2017

helfi92 commented Nov 19, 2017

eliperelman Nov 21, 2017

eliperelman left a comment

eliperelman Nov 21, 2017

eliperelman Nov 21, 2017

eliperelman Nov 21, 2017

eliperelman Nov 21, 2017

eliperelman Nov 21, 2017

eliperelman Nov 21, 2017

eliperelman Nov 21, 2017

helfi92 commented Nov 22, 2017

Add vue preset #457

Add vue preset #457

Conversation

helfi92 commented Nov 19, 2017

helfi92 commented Nov 19, 2017

Choose a reason for hiding this comment

eliperelman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

helfi92 commented Nov 22, 2017