Cleanup monorepo linting configuration

.eslintignore

@@ -0,0 +1,6 @@
+packages/**/node_modules/
+# TODO: Fix lint errors in our tests and remove this line
+packages/**/test/
+# The templates have any lint errors fixed during project creation,
+# since we don't know which ESLint preset the user will choose.
+packages/create-project/commands/init/templates/

.neutrinorc.js

@@ -1,103 +1,36 @@
 module.exports = {
   use: [
     ['./packages/airbnb-base', {
+      // Excludes are managed via `.eslintignore` since `exclude` doesn't support globs.
       include: [
         '.*.js',
-        'packages/*/*.js',
-        'packages/*/{src,bin,commands}/*.js',
-        'packages/*/commands/init/*.js',
-        'packages/neutrino/bin/*'
+        'packages/'
       ],
       eslint: {
         baseConfig: {
           extends: [
-            'plugin:react/recommended',
-            'prettier',
-            'prettier/react'
+            'prettier'
           ]
         },
         envs: ['browser', 'commonjs', 'node'],
         plugins: [
-          'eslint-plugin-prettier',
-          'eslint-plugin-react'
+          'prettier'
         ],
         rules: {
           // Algebraic and functional types should allow capital constructors without new
           'babel/new-cap': 'off',
-          // Disable necessitating return after a callback
-          'callback-return': 'off',
-          // Allow using class methods with static/non-instance functionality
-          // React lifecycle methods commonly do not use an instance context for anything
-          'class-methods-use-this': 'off',
           // Disallow trailing commas on arrays, objects, functions, et al
           'comma-dangle': ['error', 'never'],
-          // Require all requires be top-level
-          // http://eslint.org/docs/rules/global-require
-          'global-require': 'error',
-          // Enforces error handling in callbacks (node environment)
-          'handle-callback-err': 'off',
           // Allow dynamic requires
           'import/no-dynamic-require': 'off',
-          // Keep all the original Airbnb indentation rules except MemberExpression,
-          // which messes up our pretty chaining indentations
-          indent: ['error', 2, {
-            SwitchCase: 1,
-            VariableDeclarator: 1,
-            outerIIFEBody: 1,
-            MemberExpression: 'off',
-            FunctionDeclaration: {
-              parameters: 1,
-              body: 1
-            },
-            FunctionExpression: {
-              parameters: 1,
-              body: 1
-            },
-            CallExpression: {
-              arguments: 1
-            },
-            ArrayExpression: 1,
-            ObjectExpression: 1,
-            ImportDeclaration: 1,
-            flatTernaryExpressions: false,
-            ignoredNodes: ['JSXElement *']
-          }],
-          // Specify the maximum length of a line in your program
-          // JSX can get lengthy, so this helps alleviate that a bit
-          // http://eslint.org/docs/rules/max-len
-          'max-len': ['error', 120, 2, {
-            ignoreUrls: true,
-            ignoreComments: false,
-            ignoreStrings: true,
-            ignoreTemplateLiterals: true
-          }],
           // Allow console during development, otherwise throw an error
           'no-console': 'off',
-          // Allow extra parentheses since multiline JSX being wrapped in parens is considered idiomatic
-          'no-extra-parens': 'off',
-          // Disallow mixing regular variable and require declarations
-          'no-mixed-requires': ['off', false],
-          // Disallow use of new operator with the require function
-          'no-new-require': 'error',
-          // Disallow string concatenation with __dirname and __filename
-          // http://eslint.org/docs/rules/no-path-concat
-          'no-path-concat': 'error',
-          // Allow use of process.env
-          'no-process-env': 'off',
-          // Allow process.exit()
-          'no-process-exit': 'off',
-          // Restrict usage of specified node modules
-          'no-restricted-modules': 'off',
           // Allow return assign
           'no-return-assign': 'off',
           // Allowing shadowing variable that share the same context as the outer scope
           'no-shadow': 'off',
           // It makes sense to have unused expressions to avoid imperative conditionals
-          'no-unused-expressions': 'off',
-          // Allow use of synchronous methods (off by default)
-          'no-sync': 'off',
-          // Our frontend strives to adopt functional programming practices, so we prefer const over let
-          'prefer-const': 'error'
+          'no-unused-expressions': 'off'
         }
       }
     }]

package.json

@@ -41,9 +41,9 @@
     "auto-changelog": "^1.2.2",
     "ava": "^0.25.0",
     "codecov": "^3.0.0",
+    "eslint": "^4.12.1",
     "eslint-config-prettier": "^2.9.0",
     "eslint-plugin-prettier": "^2.3.1",
-    "eslint-plugin-react": "^7.5.1",
     "gh-pages": "^1.1.0",
     "gitbook-cli": "^2.3.2",
     "gitbook-plugin-anchorjs": "^1.1.1",

packages/create-project/commands/init/index.js

@@ -10,7 +10,7 @@ const { projects, packages, isYarn } = require('./utils');
 
 /* eslint-disable no-underscore-dangle */
 module.exports = class Project extends Generator {
-  _logo() {
+  static _logo() {
     return `                          _          _
       _ __    ___  _   _ | |_  _ __ (_) _ __    ___
      | '_ \\  / _ \\| | | || __|| '__|| || '_ \\  / _ \\
@@ -101,7 +101,7 @@ module.exports = class Project extends Generator {
   prompting() {
     const done = this.async();
 
-    this.log(chalk.cyan.bold(this._logo()));
+    this.log(chalk.cyan.bold(Project._logo()));
     this.log(chalk.white.bold('Welcome to Neutrino! 👋'));
     this.log(chalk.cyan('To help you create your new project, I am going to ask you a few questions.\n'));