Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build step takes a long time, each time #2

Open
ilyvion opened this issue Mar 11, 2022 · 4 comments
Open

Build step takes a long time, each time #2

ilyvion opened this issue Mar 11, 2022 · 4 comments

Comments

@ilyvion
Copy link

ilyvion commented Mar 11, 2022

The Build nev7n/wait_for_response@v1 step adds about a minute to each run, it'd be great if there was a way it could be cached between runs so you only have to build once unless something changes.
@benel
Copy link

benel commented Mar 23, 2023 •
edited
Loading

To speed up the process, I've tried to prebuild the action. Pulling the image only takes 2s instead of 42s when building it!
However, for now, I didn't succeed in passing the parameters.
See: https://stackoverflow.com/questions/75823319/how-to-pass-parameters-to-a-packaged-container-action

benel added a commit to Hypertopic/HyperGlosae that referenced this issue Mar 23, 2023
@benel
PROCESS: wait-for-response is prebuilt to speed up tests.
eaee343 
To understand the problem, see nev7n/wait_for_response#2.
To understand the solution, see https://stackoverflow.com/questions/75823319.

Please note, that due to this optimization, a synchronization had to be 
added (`test: needs: build`). Hence the whole workflow was not 
significantly optimized. However this commit will have a global effect
when pulling CouchDB image is also optimized.
@benel
Copy link

benel commented Mar 24, 2023 •
edited
Loading

Here is the solution I adopted: https://hub.docker.com/repository/docker/benel/wait-for-response/general

@ilyvion
Copy link
Author

ilyvion commented Mar 25, 2023

I don't have a docker login, so I can't see, but I still appreciate the effort. 😄

@benel
Copy link

benel commented Mar 25, 2023

I don't have a docker login, so I can't see, but I still appreciate the effort. 😄

Oops, sorry @alexschrod Wrong URI.
Here is the public one: https://hub.docker.com/r/benel/wait-for-response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benel @ilyvion