add typescript declaration for better code completion #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangbang93
changed the title
|
Wow, never thought of a PR like this. I guess I have to learn Typescript first ... |
|
Well, In fact, typescript declaration won't take any effect to runtime. It only provides type declaration in typescript compilation. Javascript can use the type declaration that provides more accurate code completion. So this should be merged safely. |
|
These declarations look good to me, we can meet to see it in detail. |
|
But to do it in the right way, we should create another library just with types, like @types/zongji |
|
The types look nice, should we add a PR for the @vlasky/zongji repo instead of this one? That one also supports MySQL 8.0+ and is a fresher version of this package. LMK your thoughts. |
|
Added an issue in that repo: vlasky#5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.