Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable auto popup for novice users #43

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

abhijitb
Copy link
Contributor

@abhijitb abhijitb commented Apr 17, 2024

Proposed changes

If the URL contained referrer=nfd-onboarding and if the user chose that he is a novice user in the onboarding flow, the help center used to open up automatically. This change prevents the Help Center from opening up automatically. With these changes, the help center will open only when the user clicks on the help center icon.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@abhijitb abhijitb merged commit ded5634 into main Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants