Fix/press0 1273 typesense index #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitb
reviewed
Jul 31, 2024
includes/MultiSearchController.php
Outdated
| $brand = sanitize_text_field( $request->get_param( 'brand' ) ); | ||
| $query = sanitize_text_field( $request->get_param( 'query' ) ); | ||
| $apiKey = 'B9wvYIokTPPgXEM3isTqsxbDOva21igT'; | ||
| $endpoint = 'https://search.hiive.cloud/multi_search?x-typesense-api-key='.$apiKey; |
There was a problem hiding this comment.
Can we move $apiKey and $endpoint as properties of the class?
abhijitb
reviewed
Jul 31, 2024
includes/MultiSearchController.php
Outdated
| * @return \WP_Error | ||
| */ | ||
| public function check_permission() { | ||
| if ( ! current_user_can( 'read' ) ) { |
There was a problem hiding this comment.
current_user_can( 'manage_options' ) seems a more robust check for this cause the help center is only available in the wordpress admin
abhijitb
approved these changes
Aug 14, 2024
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.newfold.com/browse/PRESS0-1273
Added backend endpoint to handle multi-search queries, replacing the direct Typesense API calls from the front end.
Added loader for the multi-search API call.