Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

chore: Removed unused attributes on LlmChatCompletionSummary and LlmEmbedding #278

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

bizob2828
Copy link
Member

Description

Removed attributes around legacy token counts on summary. I also fixed the embedding event to only calculate token_count if callabck is specified. Lastly, removed transaction_id from all events.

Related Issues

Closes #265

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (ce0d324) to head (dc726b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   98.00%   97.67%   -0.34%     
==========================================
  Files          23       23              
  Lines        2008     1980      -28     
==========================================
- Hits         1968     1934      -34     
- Misses         40       46       +6     
Flag Coverage Δ
unit-tests-16.x 45.80% <100.00%> (-0.96%) ⬇️
unit-tests-18.x 45.80% <100.00%> (-0.96%) ⬇️
unit-tests-20.x 45.80% <100.00%> (-0.96%) ⬇️
versioned-tests-16.x 97.42% <100.00%> (-0.34%) ⬇️
versioned-tests-18.x 97.42% <100.00%> (-0.34%) ⬇️
versioned-tests-20.x 97.42% <100.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrickard mrickard self-assigned this Apr 1, 2024
@bizob2828 bizob2828 merged commit c1a9978 into newrelic:main Apr 1, 2024
11 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
2 participants