From 431d9a1ebcbf77e790dd024f01f755f7c502c86c Mon Sep 17 00:00:00 2001 From: JGAntunes Date: Tue, 4 Jul 2017 13:57:38 +0100 Subject: [PATCH] fix: add section as a prop of ad composer --- packages/gpt/__tests__/ad-composer.test.js | 4 ++-- packages/gpt/ad-composer.js | 7 ++++++- packages/gpt/gpt.stories.js | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/packages/gpt/__tests__/ad-composer.test.js b/packages/gpt/__tests__/ad-composer.test.js index cbe0d55caf5..e0a4158f170 100644 --- a/packages/gpt/__tests__/ad-composer.test.js +++ b/packages/gpt/__tests__/ad-composer.test.js @@ -15,7 +15,7 @@ describe("AdComposer test", () => { it("renders a snapshot with one Ad", () => { const tree = renderer .create( - + ) @@ -27,7 +27,7 @@ describe("AdComposer test", () => { it("renders a snapshot with more than one Ad", () => { const tree = renderer .create( - + diff --git a/packages/gpt/ad-composer.js b/packages/gpt/ad-composer.js index a253b901f0f..5215d40f105 100644 --- a/packages/gpt/ad-composer.js +++ b/packages/gpt/ad-composer.js @@ -1,4 +1,5 @@ import React, { Component } from "react"; +import PropTypes from "prop-types"; import { Broadcast } from "react-broadcast"; import AdManager from "./ad-manager"; @@ -15,7 +16,7 @@ class AdComposer extends Component { this.adManager = new AdManager({ networkId: "25436805", adUnit: "d.thetimes.co.uk", - section: "article", + section: props.section, gptManager, pbjsManager, getSlotConfig @@ -39,4 +40,8 @@ class AdComposer extends Component { } } +AdComposer.propTypes = { + section: PropTypes.string.isRequired +}; + export default AdComposer; diff --git a/packages/gpt/gpt.stories.js b/packages/gpt/gpt.stories.js index 9dcc91ce178..573a3207eef 100644 --- a/packages/gpt/gpt.stories.js +++ b/packages/gpt/gpt.stories.js @@ -15,7 +15,7 @@ storiesOf("GPT", module).add("render two ads in article page", () => { > Render ads - +