Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct meta viewport #302

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

PaperStrike
Copy link
Member

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=2">

What is the new behavior?

<meta name="viewport" content="width=device-width">

See Correct viewport | webhint documentation for full description.

In summary, initial scale is not needed since iOS 9. Maximum scale blocks the user from zooming and is effectively ignored by some mobile browsers.

Last related PR: theme-next/hexo-theme-next#130

  • Link to demo site with this changes: sliphua.work
  • Screenshots with this changes:

How to use?

In NexT _config.yml:

@PaperStrike PaperStrike added this to the 8.6.0 milestone Jun 19, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.468% when pulling 61efa2b on PaperStrike:viewport into 566238d on next-theme:master.

@PaperStrike PaperStrike merged commit e942dc2 into next-theme:master Jun 19, 2021
@PaperStrike PaperStrike deleted the viewport branch June 19, 2021 19:43
lingyf pushed a commit to lingyf/hexo-theme-next that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants