Throw when cancelling or clicking outside

[skjnldsv]

When you click outside or close, it still returns a path: "/".

Example given: For the Move action, if you click outside, I expect to cancel.
Right now it's impossible to differentiate a cancellation and picking the root folder

[susnux]

What API?

• The FilePickerBuilder rejects the returned promise on close / cancel.
• The Vue commponent emits the close event

At least that is what should happen, if it does not, than this is a bug.

[skjnldsv]

picker.pick() should throw?
I'm not seeing this unfortunately :/

See https://github.com/nextcloud/server/blob/6c632a17c5912c330b045b6f1d85025a9d9d9f7b/apps/files/src/actions/moveOrCopyAction.ts#L200-L203, what am I doing wrong?

[susnux]

picker.pick() should throw?

Yes it should reject:

nextcloud-dialogs/lib/filepicker.ts

Line 87 in b6ad9c0

if (!nodes) reject(new Error('Nothing selected'))

[skjnldsv]

It doesn't 🙈

[susnux]

Well then this is a bug, I try to investigate