Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilePicker): Do not append image preloader to DOM #1340

Merged
merged 1 commit into from
May 27, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 27, 2024

Do not attach image elements for preloading, but just use new Image().

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels May 27, 2024
@susnux susnux requested review from ShGKme and Antreesy May 27, 2024 16:51
@susnux susnux merged commit 495fe16 into main May 27, 2024
10 checks passed
@susnux susnux deleted the fix/do-not-attach-preview-loader-to-dom branch May 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image previews are detached from dialog container
2 participants