Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FilePickerBuilder): Fix paths returned in Promise by pick method #963

Merged
merged 1 commit into from
Aug 27, 2023
Merged

fix(FilePickerBuilder): Fix paths returned in Promise by pick method #963

merged 1 commit into from
Aug 27, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 27, 2023 •
edited
Loading

@susnux susnux requested a review from skjnldsv August 27, 2023 01:30
@susnux @skjnldsv
fix(FilePickerBuilder): Fix paths returned in Promise by pick metho…
57f40c0 
…d and reject if nothing is picked

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv force-pushed the fix/filepicker-return branch from d31a45f to 57f40c0 Compare August 27, 2023 08:31
@skjnldsv skjnldsv merged commit 48bd6ad into master Aug 27, 2023
@skjnldsv skjnldsv deleted the fix/filepicker-return branch August 27, 2023 10:20
@skjnldsv skjnldsv mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pick returns invalid path, but button callback works Throw when cancelling or clicking outside
2 participants
@susnux @skjnldsv