Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcDialog): Make the heading always center aligned on top #965

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 28, 2023

As discussed the heading should always be on top and center aligned.

full size mid small
Screenshot_20230828_113421 Screenshot_20230828_113416 Screenshot_20230828_113416

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested review from skjnldsv and szaimen August 28, 2023 09:40
@susnux susnux mentioned this pull request Aug 27, 2023
15 tasks
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux susnux merged commit 012057b into master Aug 28, 2023
@susnux susnux deleted the fix/dialog-name branch August 28, 2023 18:35
@skjnldsv skjnldsv mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants