-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #759 from nextcloud-libraries/fix/add-eslint
feat: Add ESLint for linting and prettier for formatting
- Loading branch information
Showing
21 changed files
with
4,372 additions
and
636 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"extends": ["@nextcloud", "prettier"], | ||
"ignorePatterns": ["dist"], | ||
"rules": { | ||
"camelcase": ["error", { "allow": ["__pkg_version", "_nc_event_bus"] }] | ||
}, | ||
"overrides": [ | ||
{ | ||
"files": ["test/*.ts"], | ||
"rules": { | ||
"n/no-unpublished-import": "off" | ||
} | ||
}, | ||
{ | ||
"files": ["*.config.*js"], | ||
"rules": { | ||
"n/no-unpublished-import": "off" | ||
}, | ||
"parserOptions": { | ||
"babelOptions": { | ||
"parserOpts": { | ||
"plugins": ["importAttributes"] | ||
} | ||
} | ||
} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
version: 2 | ||
updates: | ||
- package-ecosystem: npm | ||
directory: "/" | ||
schedule: | ||
interval: weekly | ||
day: saturday | ||
time: "03:00" | ||
timezone: Europe/Paris | ||
versioning-strategy: increase | ||
open-pull-requests-limit: 10 | ||
- package-ecosystem: npm | ||
directory: '/' | ||
schedule: | ||
interval: weekly | ||
day: saturday | ||
time: '03:00' | ||
timezone: Europe/Paris | ||
versioning-strategy: increase | ||
open-pull-requests-limit: 10 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
# This workflow is provided via the organization template repository | ||
# | ||
# https://github.com/nextcloud/.github | ||
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization | ||
# | ||
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors | ||
# SPDX-License-Identifier: MIT | ||
|
||
name: Lint eslint | ||
|
||
on: pull_request | ||
|
||
permissions: | ||
contents: read | ||
|
||
concurrency: | ||
group: lint-eslint-${{ github.head_ref || github.run_id }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
changes: | ||
runs-on: ubuntu-latest | ||
|
||
outputs: | ||
src: ${{ steps.changes.outputs.src}} | ||
|
||
steps: | ||
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2 | ||
id: changes | ||
continue-on-error: true | ||
with: | ||
filters: | | ||
src: | ||
- '.github/workflows/**' | ||
- 'src/**' | ||
- 'appinfo/info.xml' | ||
- 'package.json' | ||
- 'package-lock.json' | ||
- 'tsconfig.json' | ||
- '.eslintrc.*' | ||
- '.eslintignore' | ||
- '**.js' | ||
- '**.ts' | ||
- '**.vue' | ||
lint: | ||
runs-on: ubuntu-latest | ||
|
||
needs: changes | ||
if: needs.changes.outputs.src != 'false' | ||
|
||
name: NPM lint | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 | ||
|
||
- name: Read package.json node and npm engines version | ||
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3 | ||
id: versions | ||
with: | ||
fallbackNode: '^20' | ||
fallbackNpm: '^10' | ||
|
||
- name: Set up node ${{ steps.versions.outputs.nodeVersion }} | ||
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v3 | ||
with: | ||
node-version: ${{ steps.versions.outputs.nodeVersion }} | ||
|
||
- name: Set up npm ${{ steps.versions.outputs.npmVersion }} | ||
run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}" | ||
|
||
- name: Install dependencies | ||
env: | ||
CYPRESS_INSTALL_BINARY: 0 | ||
PUPPETEER_SKIP_DOWNLOAD: true | ||
run: npm ci | ||
|
||
- name: Lint | ||
run: npm run lint | ||
|
||
summary: | ||
permissions: | ||
contents: none | ||
runs-on: ubuntu-latest | ||
needs: [changes, lint] | ||
|
||
if: always() | ||
|
||
# This is the summary, we just avoid to rename it so that branch protection rules still match | ||
name: eslint | ||
|
||
steps: | ||
- name: Summary status | ||
run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | ||
# SPDX-License-Identifier: MIT | ||
|
||
name: Lint prettier | ||
|
||
on: pull_request | ||
|
||
permissions: | ||
contents: read | ||
|
||
concurrency: | ||
group: lint-prettier-${{ github.head_ref || github.run_id }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
changes: | ||
runs-on: ubuntu-latest | ||
|
||
outputs: | ||
src: ${{ steps.changes.outputs.src}} | ||
|
||
steps: | ||
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2 | ||
id: changes | ||
continue-on-error: true | ||
with: | ||
filters: | | ||
src: | ||
- '.github/workflows/**' | ||
- 'lib/**' | ||
- 'appinfo/info.xml' | ||
- 'package.json' | ||
- 'package-lock.json' | ||
- 'tsconfig.json' | ||
- '.prettierignore' | ||
- '**.js' | ||
- '**.ts' | ||
- '**.vue' | ||
- '**.yml' | ||
- '**.md' | ||
lint: | ||
runs-on: ubuntu-latest | ||
|
||
needs: changes | ||
if: needs.changes.outputs.src != 'false' | ||
|
||
name: NPM format | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 | ||
|
||
- name: Read package.json node and npm engines version | ||
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3 | ||
id: versions | ||
with: | ||
fallbackNode: '^20' | ||
fallbackNpm: '^10' | ||
|
||
- name: Set up node ${{ steps.versions.outputs.nodeVersion }} | ||
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v3 | ||
with: | ||
node-version: ${{ steps.versions.outputs.nodeVersion }} | ||
|
||
- name: Set up npm ${{ steps.versions.outputs.npmVersion }} | ||
run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}" | ||
|
||
- name: Install dependencies | ||
env: | ||
CYPRESS_INSTALL_BINARY: 0 | ||
PUPPETEER_SKIP_DOWNLOAD: true | ||
run: npm ci | ||
|
||
- name: Format | ||
run: npm run format | ||
|
||
summary: | ||
permissions: | ||
contents: none | ||
runs-on: ubuntu-latest | ||
needs: [changes, lint] | ||
|
||
if: always() | ||
|
||
# This is the summary, we just avoid to rename it so that branch protection rules still match | ||
name: prettier | ||
|
||
steps: | ||
- name: Summary status | ||
run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# version control systems directories | ||
**/.git | ||
|
||
# 3rdparty dependencies | ||
**/node_modules | ||
|
||
# Compiled JS output | ||
dist/ | ||
|
||
# other misc stuff | ||
coverage/ |
Oops, something went wrong.