From e9208c30c02b6228cf9467158694f4626fc9e398 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Raimund=20Schl=C3=BC=C3=9Fler?=
 <raimund.schluessler@mailbox.org>
Date: Wed, 1 Nov 2023 21:35:38 +0100
Subject: [PATCH] feat(NcUserBubble): migrate to vue 3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
---
 .eslintrc.js                                 |  2 --
 src/components/NcUserBubble/NcUserBubble.vue | 25 ++------------------
 src/components/index.js                      |  2 +-
 styleguide.config.js                         |  3 +--
 4 files changed, 4 insertions(+), 28 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index e30a51405d..60d30e52df 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -23,8 +23,6 @@ module.exports = {
 		'src/components/NcDashboard*/*.vue',
 		'src/components/NcRelatedResourcesPanel*/*.vue',
 		'src/components/NcRich*/**/*.vue',
-		'src/components/NcUserBubble*/*.vue',
-		'src/components/NcVNodes*/*.vue',
 		'src/utils/IsMobileState.js',
 	],
 	parserOptions: {
diff --git a/src/components/NcUserBubble/NcUserBubble.vue b/src/components/NcUserBubble/NcUserBubble.vue
index a1858e7067..af5b70a585 100644
--- a/src/components/NcUserBubble/NcUserBubble.vue
+++ b/src/components/NcUserBubble/NcUserBubble.vue
@@ -77,7 +77,7 @@ export default {
 
 </docs>
 <template>
-	<component :is="isPopoverComponent"
+	<component :is="!!$slots.default ? 'NcPopover' : 'NcUserBubbleDiv'"
 		trigger="hover focus"
 		:shown="open"
 		class="user-bubble__wrapper"
@@ -108,7 +108,7 @@ export default {
 				</span>
 
 				<!-- @slot Optional slot just after the name -->
-				<span v-if="$slots.name" class="user-bubble__secondary">
+				<span v-if="!!$slots.name" class="user-bubble__secondary">
 					<slot name="name" />
 				</span>
 			</component>
@@ -211,20 +211,6 @@ export default {
 		'update:open',
 	],
 	computed: {
-		/**
-		 * If userbubble is empty, let's NOT
-		 * use the Popover component
-		 * We need a component instead of a simple div here,
-		 * because otherwise the trigger template will not be shown.
-		 *
-		 * @return {string} 'Popover' or 'UserBubbleDiv'
-		 */
-		isPopoverComponent() {
-			return !this.popoverEmpty
-				? 'NcPopover'
-				: 'NcUserBubbleDiv'
-		},
-
 		/**
 		 * Is the provided avatar url valid or not
 		 *
@@ -259,13 +245,6 @@ export default {
 			return this.hasUrl ? 'a' : 'div'
 		},
 
-		popoverEmpty() {
-			if ('default' in this.$slots) {
-				return false
-			}
-			return true
-		},
-
 		styles() {
 			return {
 				content: {
diff --git a/src/components/index.js b/src/components/index.js
index e267f5fb4e..d89751630e 100644
--- a/src/components/index.js
+++ b/src/components/index.js
@@ -94,4 +94,4 @@ export { default as NcSettingsSelectGroup } from './NcSettingsSelectGroup/index.
 export { default as NcTextArea } from './NcTextArea/index.js'
 export { default as NcTextField } from './NcTextField/index.js'
 export { default as NcTimezonePicker } from './NcTimezonePicker/index.js'
-// export { default as NcUserBubble } from './NcUserBubble/index.js'
+export { default as NcUserBubble } from './NcUserBubble/index.js'
diff --git a/styleguide.config.js b/styleguide.config.js
index 64de13c45c..be91783090 100644
--- a/styleguide.config.js
+++ b/styleguide.config.js
@@ -116,12 +116,11 @@ module.exports = async () => {
 					'src/components/NcSettings*/*.vue',
 					'src/components/NcTextArea/*.vue',
 					'src/components/NcUserBubble/NcUserBubbleDiv.vue',
+					'src/components/NcVNodes*/*.vue',
 
 					// Not yet adjusted for vue3
 					'src/components/NcRelatedResourcesPanel*/*.vue',
 					'src/components/NcRichContenteditable*/*.vue',
-					'src/components/NcUserBubble*/*.vue',
-					'src/components/NcVNodes*/*.vue',
 				],
 				sections: [
 					{