From ab030ac48ac10eedc868d70c3a61cd86ba6cebbf Mon Sep 17 00:00:00 2001
From: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Date: Fri, 10 Mar 2023 12:45:15 +0100
Subject: [PATCH 1/3] fix(NcPopover): fix attrs doubling

- Add `inheritAttrs: false` to prevent attrs doubling
- Add props passing example to the docs
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
---
 src/components/NcPopover/NcPopover.vue | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/components/NcPopover/NcPopover.vue b/src/components/NcPopover/NcPopover.vue
index 5b428647dd..a6e4464b97 100644
--- a/src/components/NcPopover/NcPopover.vue
+++ b/src/components/NcPopover/NcPopover.vue
@@ -79,6 +79,21 @@ The prop `:focus-trap="false"` help to prevent it when the default behavior is n
 	</NcPopover>
 </template>
 ```
+
+#### With passing props to `floating-vue`'s `Dropdown`:
+
+```vue
+<template>
+	<NcPopover container="body" :popper-hide-triggers="(triggers) => [...triggers, 'click']">
+		<template #trigger>
+			<NcButton>I am the trigger</NcButton>
+		</template>
+		<template #default>
+			<NcButton>Click on the button will close NcPopover</NcButton>
+		</template>
+	</NcPopover>
+</template>
+```
 </docs>
 
 <template>
@@ -107,10 +122,13 @@ import { getTrapStack } from '../../utils/focusTrap.js'
 
 export default {
 	name: 'NcPopover',
+
 	components: {
 		Dropdown,
 	},
 
+	inheritAttrs: false,
+
 	props: {
 		popoverBaseClass: {
 			type: String,

From e307ffd2ed671435cf2bf2c27bf40c089fc2926f Mon Sep 17 00:00:00 2001
From: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Date: Fri, 10 Mar 2023 12:47:19 +0100
Subject: [PATCH 2/3] docs(NcPopover): fix typos

Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
---
 src/components/NcPopover/NcPopover.vue | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/components/NcPopover/NcPopover.vue b/src/components/NcPopover/NcPopover.vue
index a6e4464b97..15116232f9 100644
--- a/src/components/NcPopover/NcPopover.vue
+++ b/src/components/NcPopover/NcPopover.vue
@@ -42,18 +42,18 @@ open prop on this component;
 <template>
 	<NcPopover>
 		<template #trigger>
-			<NcButton> I am the trigger </NcButton>
+			<NcButton>I am the trigger</NcButton>
 		</template>
 		<template>
 			<form tabindex="0" @submit.prevent>
 				<h2>this is some content</h2>
 				<p>
-					Lorem ipsum dolor sit amet, consectetur adipiscing elit. </br>
+					Lorem ipsum dolor sit amet, consectetur adipiscing elit. <br />
 					Vestibulum eget placerat velit.
 				</p>
 				<label>
 					Label element
-					<input type="text" placehold="input element" />
+					<input type="text" placeholder="input element" />
 				</label>
 			</form>
 		</template>
@@ -71,7 +71,7 @@ The prop `:focus-trap="false"` help to prevent it when the default behavior is n
 <template>
 	<NcPopover :focus-trap="false">
 		<template #trigger>
-			<NcButton> Click me! </NcButton>
+			<NcButton>Click me!</NcButton>
 		</template>
 		<template>
 			Hi! 🚀

From 56ddd3a49aa43ac3de68efc5416724648322cfc6 Mon Sep 17 00:00:00 2001
From: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Date: Fri, 10 Mar 2023 12:49:11 +0100
Subject: [PATCH 3/3] docs(NcPopover): fix Popover positions in examples

Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
---
 src/components/NcPopover/NcPopover.vue | 74 ++++++++++++++------------
 1 file changed, 40 insertions(+), 34 deletions(-)

diff --git a/src/components/NcPopover/NcPopover.vue b/src/components/NcPopover/NcPopover.vue
index 15116232f9..86195cfb89 100644
--- a/src/components/NcPopover/NcPopover.vue
+++ b/src/components/NcPopover/NcPopover.vue
@@ -40,24 +40,26 @@ open prop on this component;
 
 ```vue
 <template>
-	<NcPopover>
-		<template #trigger>
-			<NcButton>I am the trigger</NcButton>
-		</template>
-		<template>
-			<form tabindex="0" @submit.prevent>
-				<h2>this is some content</h2>
-				<p>
-					Lorem ipsum dolor sit amet, consectetur adipiscing elit. <br />
-					Vestibulum eget placerat velit.
-				</p>
-				<label>
-					Label element
-					<input type="text" placeholder="input element" />
-				</label>
-			</form>
-		</template>
-	</NcPopover>
+	<div style="display: flex">
+		<NcPopover>
+			<template #trigger>
+				<NcButton>I am the trigger</NcButton>
+			</template>
+			<template>
+				<form tabindex="0" @submit.prevent>
+					<h2>this is some content</h2>
+					<p>
+						Lorem ipsum dolor sit amet, consectetur adipiscing elit. <br/>
+						Vestibulum eget placerat velit.
+					</p>
+					<label>
+						Label element
+						<input type="text" placeholder="input element"/>
+					</label>
+				</form>
+			</template>
+		</NcPopover>
+	</div>
 </template>
 ```
 
@@ -69,14 +71,16 @@ The prop `:focus-trap="false"` help to prevent it when the default behavior is n
 
 ```vue
 <template>
-	<NcPopover :focus-trap="false">
-		<template #trigger>
-			<NcButton>Click me!</NcButton>
-		</template>
-		<template>
-			Hi! 🚀
-		</template>
-	</NcPopover>
+	<div style="display: flex">
+		<NcPopover :focus-trap="false">
+			<template #trigger>
+				<NcButton>Click me!</NcButton>
+			</template>
+			<template>
+				Hi! 🚀
+			</template>
+		</NcPopover>
+	</div>
 </template>
 ```
 
@@ -84,14 +88,16 @@ The prop `:focus-trap="false"` help to prevent it when the default behavior is n
 
 ```vue
 <template>
-	<NcPopover container="body" :popper-hide-triggers="(triggers) => [...triggers, 'click']">
-		<template #trigger>
-			<NcButton>I am the trigger</NcButton>
-		</template>
-		<template #default>
-			<NcButton>Click on the button will close NcPopover</NcButton>
-		</template>
-	</NcPopover>
+	<div style="display: flex">
+		<NcPopover container="body" :popper-hide-triggers="(triggers) => [...triggers, 'click']">
+			<template #trigger>
+				<NcButton>I am the trigger</NcButton>
+			</template>
+			<template #default>
+				<NcButton>Click on the button will close NcPopover</NcButton>
+			</template>
+		</NcPopover>
+	</div>
 </template>
 ```
 </docs>