From 5b583738989adab74e844f135d81f9b7dc8ea2a5 Mon Sep 17 00:00:00 2001 From: Carl Schwan Date: Mon, 12 Sep 2022 11:28:23 +0200 Subject: [PATCH] Fix a word puzzle in NcDashboardWidget component Instead of having a prop that allows customizing one part of a sentence, use a prop to allow changing the full sentences. Fix https://github.com/nextcloud/activity/issues/919 Signed-off-by: Carl Schwan --- l10n/messages.pot | 5 +---- .../NcDashboardWidget/NcDashboardWidget.vue | 12 +++++------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/l10n/messages.pot b/l10n/messages.pot index 8923f859ee..4f5b6d73be 100644 --- a/l10n/messages.pot +++ b/l10n/messages.pot @@ -83,13 +83,10 @@ msgstr "" msgid "Hide password" msgstr "" -msgid "items" -msgstr "" - msgid "Message limit of {count} characters reached" msgstr "" -msgid "More {dashboardItemType} …" +msgid "More items …" msgstr "" msgid "Next" diff --git a/src/components/NcDashboardWidget/NcDashboardWidget.vue b/src/components/NcDashboardWidget/NcDashboardWidget.vue index 151ef2b5db..781a9a4dd9 100644 --- a/src/components/NcDashboardWidget/NcDashboardWidget.vue +++ b/src/components/NcDashboardWidget/NcDashboardWidget.vue @@ -230,11 +230,13 @@ export default { default: '', }, /** - * The type of elements to show more. + * The text of show more button. + * + * Expected to be in the form "More {itemName} …" */ - showMoreText: { + showMoreLabel: { type: String, - default: t('items'), + default: t('More items …'), }, /** * A boolean to put the widget in a loading state. @@ -307,10 +309,6 @@ export default { showMore() { return this.showMoreUrl && this.items.length >= this.maxItemNumber }, - - showMoreLabel() { - return t('More {dashboardItemType} …', { dashboardItemType: this.showMoreText }) - }, }, }