Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigationCaption): Make color main-text for accessibility #4885

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix(NcAppNavigationCaption): Make color main-text for accessibility #4885

merged 1 commit into from
Nov 29, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 29, 2023

☑️ Resolves

Currently the text is not readable, especially on dark mode. So lets move to main text color instead.
image

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2023-11-29 at 15-58-25 Nextcloud Vue Style Guide Screenshot 2023-11-29 at 15-56-55 Nextcloud Vue Style Guide
Screenshot 2023-11-29 at 15-59-45 Nextcloud Vue Style Guide Screenshot 2023-11-29 at 16-00-47 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux
fix(NcAppNavigationCaption): Make color main-text for accessibility
c2763e2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 29, 2023
@susnux susnux added this to the 8.2.1 milestone Nov 29, 2023
@susnux susnux requested a review from Pytal November 29, 2023 23:23
@susnux susnux enabled auto-merge November 29, 2023 23:23
@susnux susnux merged commit ea6ba30 into master Nov 29, 2023
15 checks passed
@susnux susnux deleted the fix/app-navigation-caption-color branch November 29, 2023 23:24
@susnux
Copy link
Contributor Author

susnux commented Nov 30, 2023

Resolves: nextcloud/server#41850

This was referenced Nov 30, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Pytal approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @Pytal @ShGKme