Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrongly inverted icon #1510

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix wrongly inverted icon #1510

merged 2 commits into from
Jan 15, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 15, 2024 •
edited
Loading

Fix #1462

Before After
image image
For my own testing 
docker run -it --rm ^
--name nextcloud-easy-test ^
-p 8443:443 ^
-e ACTIVITY_BRANCH=enh/noid/fix-icon ^
-e SERVER_BRANCH=master ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 29 milestone Jan 15, 2024
@szaimen
Copy link
Contributor Author

szaimen commented Jan 15, 2024

Doesn't seem to work yet...

@szaimen szaimen marked this pull request as draft January 15, 2024 11:49
@szaimen
fix wrongly inverted icon
b800882 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen marked this pull request as ready for review January 15, 2024 12:08
@szaimen
Copy link
Contributor Author

szaimen commented Jan 15, 2024

Works now and ready for review :)

@cypress Cypress
Copy link

cypress bot commented Jan 15, 2024 •
edited
Loading

Passing run #1127 ↗︎

0 10 0 0 Flakiness 0

Details:

fix wrongly inverted icon
Project: Activity Commit: 8773901ad6
Status: Passed Duration: 02:24 💡
Started: Jan 15, 2024 1:22 PM Ended: Jan 15, 2024 1:24 PM

Review all test suite changes for PR #1510 ↗︎

@szaimen
Copy link
Contributor Author

szaimen commented Jan 15, 2024

/compile

@szaimen
Copy link
Contributor Author

szaimen commented Jan 15, 2024

/backport b800882 to stable28

@szaimen szaimen enabled auto-merge January 15, 2024 12:53
@nextcloud-command
chore(assets): Recompile assets
5d03a65 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen merged commit 77c7b23 into master Jan 15, 2024
43 checks passed
@szaimen szaimen deleted the enh/noid/fix-icon branch January 15, 2024 13:34
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 15, 2024
Merged
jancborchardt
jancborchardt approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice! :)

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@susnux susnux Awaiting requested review from susnux

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review bug design
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Icons of selected entries in navigation are not inverted according to background highlight
4 participants
@szaimen @jancborchardt @artonge @nextcloud-command