diff --git a/php/containers.json b/php/containers.json index 99c9a181d87..34a7b0d248e 100644 --- a/php/containers.json +++ b/php/containers.json @@ -475,6 +475,7 @@ "protocol": "tcp" } ], + "internal_port": "%APACHE_PORT%", "environment": [ "INSTANCE_ID=%INSTANCE_ID%", "APACHE_PORT=%APACHE_PORT%" diff --git a/php/public/index.php b/php/public/index.php index 87421cdc650..de46eb411dc 100644 --- a/php/public/index.php +++ b/php/public/index.php @@ -176,6 +176,6 @@ } }); -$errorMiddleware = $app->addErrorMiddleware(true, true, true); +$errorMiddleware = $app->addErrorMiddleware(false, true, true); $app->run(); diff --git a/php/src/Controller/DockerController.php b/php/src/Controller/DockerController.php index cdb8b057db1..8f29949b7ae 100644 --- a/php/src/Controller/DockerController.php +++ b/php/src/Controller/DockerController.php @@ -255,7 +255,11 @@ public function StartDomaincheckContainer() : void } $this->StopDomaincheckContainer(); - $this->PerformRecursiveContainerStart($id); + try { + $this->PerformRecursiveContainerStart($id); + } catch (\Exception $e) { + error_log('Could not start domaincheck container: ' . $e->getMessage()); + } // Cache the start for 10 minutes apcu_add($cacheKey, '1', 600); diff --git a/php/templates/containers.twig b/php/templates/containers.twig index b4589e224c9..f5f12b3e6c9 100644 --- a/php/templates/containers.twig +++ b/php/templates/containers.twig @@ -24,6 +24,7 @@ {% set isAnyRunning = false %} {% set isAnyRestarting = false %} {% set isWatchtowerRunning = false %} + {% set isDomaincheckRunning = false %} {% set isBackupOrRestoreRunning = false %} {% set isApacheStarting = false %} {# Setting newMajorVersion to '' will hide corresponding options/elements, can be set to an integer like 26 in order to show corresponding elements. If set, also increase installLatestMajor in https://github.com/nextcloud/all-in-one/blob/main/php/src/Controller/DockerController.php #} @@ -45,6 +46,9 @@ {% if container.GetIdentifier() == 'nextcloud-aio-watchtower' and class(container.GetRunningState()) == 'AIO\\Container\\State\\RunningState' %} {% set isWatchtowerRunning = true %} {% endif %} + {% if container.GetIdentifier() == 'nextcloud-aio-domaincheck' and class(container.GetRunningState()) == 'AIO\\Container\\State\\RunningState' %} + {% set isDomaincheckRunning = true %} + {% endif %} {% if container.GetIdentifier() == 'nextcloud-aio-apache' and class(container.GetStartingState()) == 'AIO\\Container\\State\\StartingState' %} {% set isApacheStarting = true %} {% endif %} @@ -69,7 +73,10 @@ Reload ↻
{% else %} {% if is_backup_container_running == false and domain == "" %} - {% if is_mastercontainer_update_available == true %} + {% if isDomaincheckRunning == false %} +

Domaincheck container is not running

+ This is not expected. Most likely this happened because port {{ apache_port }} is already in use on your server. You can check the mastercontainer logs and domaincheck container logs for further clues. You should be able to resolve this by adjusting the APACHE_PORT by following the reverse proxy documentation. Advice: have a detailed look at the changed docker run command for AIO. + {% elseif is_mastercontainer_update_available == true %}

Mastercontainer update

⚠️ A mastercontainer update is available. Please click on the button below to update it. Afterwards, you will be able to proceed with the setup.