Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borgbackup: make logs a bit cleaner if local archive is used #5553

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Nov 8, 2024

Follow-up to #4804

Prevent logs like the following when used with local archive:

cat: can't open '.pub': No such file or directory
Your public ssh key for borgbackup is: 

Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews bug Something isn't working borg labels Nov 8, 2024
@szaimen szaimen added this to the next milestone Nov 8, 2024
@szaimen szaimen requested a review from timdiels November 8, 2024 13:31
Copy link
Collaborator

@timdiels timdiels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, LGTM

Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/4804/clean-borg branch from 4384a24 to ccf445a Compare November 8, 2024 13:56
@szaimen szaimen merged commit 267aebf into main Nov 8, 2024
4 checks passed
@szaimen szaimen deleted the enh/4804/clean-borg branch November 8, 2024 13:57
@timdiels
Copy link
Collaborator

timdiels commented Nov 8, 2024

Nit: I would merge both ifs

  • if remote
    • if key does not exist, create it
    • if key exists, cat it

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 8, 2024

Nit: I would merge both ifs

  • if remote

    • if key does not exist, create it
    • if key exists, cat it

I see... Do you want to create a PR? :)

@timdiels
Copy link
Collaborator

timdiels commented Nov 8, 2024

No no, either is fine really

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews borg bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants