-
Notifications
You must be signed in to change notification settings - Fork 53
feat: Add interactive vue-based teams dashboard widget #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
66b4446 to
0c012e3
Compare
nfebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes
- Since we now used vue-based widget, it could be possible to move the js code to the contacts app
- Based on questions in : #1942 (comment) we could add tooltips that provide more context on file hovers.
0c012e3 to
42945e9
Compare
|
Looks good to me, just some minor comments to be checked with @jancborchardt In the last call we decided to have the app icon on the bottom right of each resource to know its origin The original mockup hat a right scroll ability on the list the above video shows a '+X' items visual instead which should be approved by designers. In any way of doable as a quick follow up PR I'd be fine to merge. |
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a build system for the vue components - the circles app is not available in Nextcloud build time!
(Also it should be then moved to the src directory rather then js)
@susnux please see nextcloud/server#54467 (comment), if we can't use the core build system (like I added in server) then I think the best option would be to move this to the contacts app. |
|
Looks nice, thank you for the effort. Two things I'd change are:
Yes, that would be really nice as filenames are not displayed at all at the moment as far as I can tell.
This looks good to me, it's a good solution :) |
|
Also, is the show more button using secondary styling? It's hard to tell. It should :) |
eb118ec to
15bf53d
Compare
15bf53d to
0b77357
Compare
|
(Took over due to vacations) Added the build system:
Additionally to that I also used directly Vue 3 instead. Content wise only following is changed:
|
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font size of the team names could also be reduced to the normal text size (bolded) so there's more space to vertically separate the individual teams, like @kra-mo mentioned?
|
Included fixed for open issues:
|
f233ddd to
ab05279
Compare
- Add Vue-based dashboard widget showing teams with members and resources - Implement paginated loading with show more functionality - Display file previews with fallback icons - Add dedicated API endpoint for data fetching - Include clickable elements linking to team pages Co-authored-by: nfebe <fenn25.fn@gmail.com> Co-authored-by: Louis <louis@chmn.me> Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
fb2284c to
87857f8
Compare
Video
new-teams-widget.mp4
Resolves: #1938