Skip to content

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Aug 16, 2025

Before After
image image

Video

new-teams-widget.mp4

Resolves: #1938

@nfebe nfebe added this to the Nextcloud 32 milestone Aug 16, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Aug 16, 2025
@nfebe nfebe force-pushed the feat/1942/teams-dashboard-widget branch 3 times, most recently from 66b4446 to 0c012e3 Compare August 16, 2025 14:34
Copy link
Contributor Author

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes

  • Since we now used vue-based widget, it could be possible to move the js code to the contacts app
  • Based on questions in : #1942 (comment) we could add tooltips that provide more context on file hovers.

@AndyScherzinger
Copy link
Member

Looks good to me, just some minor comments to be checked with @jancborchardt

In the last call we decided to have the app icon on the bottom right of each resource to know its origin

The original mockup hat a right scroll ability on the list the above video shows a '+X' items visual instead which should be approved by designers.

In any way of doable as a quick follow up PR I'd be fine to merge.

susnux
susnux previously requested changes Aug 16, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a build system for the vue components - the circles app is not available in Nextcloud build time!
(Also it should be then moved to the src directory rather then js)

@nfebe
Copy link
Contributor Author

nfebe commented Aug 17, 2025

This needs a build system for the vue components - the circles app is not available in Nextcloud build time!
(Also it should be then moved to the src directory rather then js)

@susnux please see nextcloud/server#54467 (comment), if we can't use the core build system (like I added in server) then I think the best option would be to move this to the contacts app.

@kra-mo
Copy link
Member

kra-mo commented Aug 19, 2025

Looks nice, thank you for the effort.

Two things I'd change are:

  1. If possible, increase the spacing between the members and resources list slightly.
  2. Rename "Show more teams" to just "More teams".

we could add tooltips that provide more context on file hovers.

Yes, that would be really nice as filenames are not displayed at all at the moment as far as I can tell.

The original mockup had a right scroll ability on the list the above video shows a '+X' items visual instead which should be approved by designers.

This looks good to me, it's a good solution :)

@kra-mo
Copy link
Member

kra-mo commented Aug 19, 2025

Also, is the show more button using secondary styling? It's hard to tell. It should :)

@susnux susnux force-pushed the feat/1942/teams-dashboard-widget branch from eb118ec to 15bf53d Compare August 19, 2025 22:25
@susnux susnux self-requested a review August 19, 2025 22:25
@susnux susnux force-pushed the feat/1942/teams-dashboard-widget branch from 15bf53d to 0b77357 Compare August 19, 2025 22:28
@susnux susnux dismissed their stale review August 19, 2025 22:28

Added the build system

@susnux
Copy link
Contributor

susnux commented Aug 19, 2025

(Took over due to vacations)

Added the build system:

  • Add basic vite based build system
  • Added ESLint workflow
  • Added Typescript setup
  • Fixed linter issues
  • Added necessary CI workflows

Additionally to that I also used directly Vue 3 instead.

Content wise only following is changed:

  • The changes requested by @kra-mo are now implemented (spacing and wording).
  • As well as the button is secondary as requested.

@susnux susnux removed their request for review August 19, 2025 22:31
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font size of the team names could also be reduced to the normal text size (bolded) so there's more space to vertically separate the individual teams, like @kra-mo mentioned?

@susnux
Copy link
Contributor

susnux commented Aug 20, 2025

Included fixed for open issues:

  • "If possible, increase the spacing between the members and resources list slightly." (@kra-mo )
  • "Rename "Show more teams" to just "More teams"." (@kra-mo )
  • "show more button using secondary styling" (@kra-mo )
  • "add tooltips that provide more context on file hovers."
  • "font size of the team names could also be reduced [...] so there's more space to vertically separate the individual teams" (@jancborchardt )

@susnux susnux force-pushed the feat/1942/teams-dashboard-widget branch 2 times, most recently from f233ddd to ab05279 Compare August 20, 2025 09:47
nfebe and others added 11 commits August 21, 2025 09:22
- Add Vue-based dashboard widget showing teams with members and resources
- Implement paginated loading with show more functionality
- Display file previews with fallback icons
- Add dedicated API endpoint for data fetching
- Include clickable elements linking to team pages

Co-authored-by: nfebe <fenn25.fn@gmail.com>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/1942/teams-dashboard-widget branch from fb2284c to 87857f8 Compare August 21, 2025 07:24
@susnux susnux merged commit cae799c into master Aug 21, 2025
40 checks passed
@susnux susnux deleted the feat/1942/teams-dashboard-widget branch August 21, 2025 07:48
@sorbaugh sorbaugh moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Sep 5, 2025
@susnux susnux linked an issue Sep 10, 2025 that may be closed by this pull request
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

👥 Teams - Roadmap for NC32 Teams dashboard widget avatars are not circular

8 participants