Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circles integration #2098

Merged
merged 17 commits into from
Jun 1, 2021
Merged

Circles integration #2098

merged 17 commits into from
Jun 1, 2021

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 3, 2021

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.comSigned-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv force-pushed the enh/circles-cleanup branch from aac06cc to d1eaaa4 Compare March 3, 2021 12:21
@skjnldsv skjnldsv self-assigned this Mar 3, 2021
@skjnldsv skjnldsv changed the title Move Navigation to dedicated component Circles integration Mar 3, 2021
@skjnldsv skjnldsv force-pushed the enh/circles-cleanup branch from d1eaaa4 to c79808f Compare March 3, 2021 12:24
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #2098 (b9fff7a) into master (fcba7ff) will decrease coverage by 0.54%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2098      +/-   ##
============================================
- Coverage     69.83%   69.28%   -0.55%     
+ Complexity      238      236       -2     
============================================
  Files            22       22              
  Lines           673      674       +1     
============================================
- Hits            470      467       -3     
- Misses          203      207       +4     
Impacted Files Coverage Δ
appinfo/routes.php 0.00% <ø> (ø)
lib/Controller/ContactsController.php 66.66% <0.00%> (-33.34%) ⬇️
lib/ContactsMenu/Providers/DetailsProvider.php 96.55% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcba7ff...b9fff7a. Read the comment docs.

@skjnldsv skjnldsv changed the base branch from enh/circles-cleanup to master May 3, 2021 17:01
@skjnldsv skjnldsv force-pushed the enh/circles branch 4 times, most recently from 4604aeb to f9a2df4 Compare May 4, 2021 06:08
skjnldsv added 12 commits May 30, 2021 10:28
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv added 2 commits May 30, 2021 10:28
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels May 30, 2021
skjnldsv added 2 commits June 1, 2021 08:19
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 1f8f133 into master Jun 1, 2021
@skjnldsv skjnldsv deleted the enh/circles branch June 1, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: circles feature: contacts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant