Skip to content

Update master php testing versions #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 4, 2022
Merged

Update master php testing versions #64

merged 5 commits into from
Apr 4, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 4, 2022 •
edited
Loading

Fix #58

@nickvergessen
Update master php testing versions
af839e9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Apr 4, 2022
Closed
45 tasks
@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 4, 2022

PHP Fatal error: Could not check compatibility between PHPUnit\PharIo\Manifest\AuthorCollection::getIterator(): PHPUnit\PharIo\Manifest\AuthorCollectionIterator and IteratorAggregate::getIterator(): Traversable, because class PHPUnit\PharIo\Manifest\AuthorCollectionIterator is not available in phar:///usr/local/bin/phpunit/phar-io-manifest/values/AuthorCollection.php on line 33
Error: Process completed with exit code 255.

PHPUnit version is pinned to incompatible version

come-nc added 2 commits April 4, 2022 14:45
@come-nc
composer update
6076e57 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Do not pin phpunit version
c483424 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc self-assigned this Apr 4, 2022
@come-nc
Copy link
Contributor

come-nc commented Apr 4, 2022

@nickvergessen Not sure if the drone step can be removed? What about scrutinizer?

@nickvergessen
Replace drone with github action
de131ed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@come-nc
Copy link
Contributor

come-nc commented Apr 4, 2022

@nickvergessen is php-parallel-lint/php-parallel-lint still a dev requirement?

@nickvergessen
Remove unused dependency
7fb5657 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 4, 2022

nickvergessen is php-parallel-lint/php-parallel-lint still a dev requirement?

Removed

@come-nc come-nc merged commit ec23173 into master Apr 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-master-php-testing-versions branch April 4, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

Assignees

@come-nc come-nc

Labels

4. to release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace drone with github actions

4 participants

@nickvergessen @come-nc @blizzz