Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translationtool): add Python support for translations #629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrey18106
Copy link
Contributor

As the Python language is mostly used in ExApps (AppAPI) for now - introduce support for it in translationtool.

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@nickvergessen
Copy link
Member

Do this apps need the other bits as well (info.xml, php, js, vue), or are they Python only and could be translated directly from Python to Transifex?

@andrey18106
Copy link
Contributor Author

Do this apps need the other bits as well (info.xml, php, js, vue)

info.xml, js and vue are also present in Python apps (see boilerplate), basically only Python backend differs.

The only thing I forgot is that we need to adjust CI for such apps on what is committed to repository from transifex, in particular keep .po and .mo files with translations too, how could we do this in better way?

@nickvergessen
Copy link
Member

The only thing I forgot is that we need to adjust CI for such apps on what is committed to repository from transifex, in particular keep .po and .mo files with translations too, how could we do this in better way?

We definitely don't want this for the other apps. Is python reading it directly from there?

@nickvergessen
Copy link
Member

Maybe we need to add a new "category"/"type" then which simply runs a bit of another workflow. Any file which we can check existance for?

@andrey18106
Copy link
Contributor Author

Is python reading it directly from there?

Yes. For sure you can implement it in different way, but it would be similar to how it's done in Nextcloud, by converting translations into needed format from .po files, so that's why they might be needed for ExApps, developers can decide on their own how to handle these translation files in their app.

Any file which we can check existance for?

Any file to check to detect this "ExApps category"? Well, for example ExApp's appinfo/info.xml should contain external-app section.

@nickvergessen
Copy link
Member

Well, for example ExApp's appinfo/info.xml should contain external-app section.

Should be able to get that yeah, similar to
https://github.com/nextcloud/docker-ci/blob/master/translations-app/handleAppTranslations.sh#L19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants