Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase (double) opcache string buffer size #1702

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

rugk
Copy link
Contributor

@rugk rugk commented Feb 19, 2022

This fixes #1692
Fixes nextcloud/server#31223

@rugk
Copy link
Contributor Author

rugk commented Feb 19, 2022

Do I really need that signoff thingy? One cannot do it online with GitHubs UI so I'd need to clone the repo… uff…

@rugk
Copy link
Contributor Author

rugk commented Feb 19, 2022

See also: #1703

@MichaIng
Copy link
Member

Hey guys. What do you think about removing all the other OPcache settings? Those are PHP defaults anyway, with the exception of opcache.revalidate_freq which defaults to 2. This however may be better to set to at least 5 or even higher, Nextcloud AIO uses 60 seconds. This is the amount of seconds after which PHP will revalidate timestamps of cached scripts (hence does disk access) on requests. It is only relevant when config.php is edited, defining the maximum time after which the change takes effect. 5 seconds should be sufficiently fast, I think?

Copy link
Contributor

@J0WI J0WI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J0WI
Copy link
Contributor

J0WI commented Mar 23, 2022

#1702 (comment)

I'll fix this in a follow up

@J0WI J0WI merged commit 6478d4d into nextcloud:master Mar 23, 2022
@rugk rugk deleted the patch-1 branch March 23, 2022 11:39
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 23, 2022
Changes:

- https///github.com/nextcloud/docker/commit/fb33f15: Runs update.sh
- https///github.com/nextcloud/docker/commit/d27ec71: Set recommend opcache.revalidate_freq (https///github.com/nextcloud/docker/pull/1718)
- https///github.com/nextcloud/docker/commit/7d6837d: Remove Nextcloud 21 (EOL) (https///github.com/nextcloud/docker/pull/1719)
- https///github.com/nextcloud/docker/commit/04d461e: Runs update.sh
- https///github.com/nextcloud/docker/commit/6478d4d: Increase (double) opcache string buffer size (https///github.com/nextcloud/docker/pull/1702)
- https///github.com/nextcloud/docker/commit/df168e1: Runs update.sh
- https///github.com/nextcloud/docker/commit/3a5086d: Runs update.sh
- https///github.com/nextcloud/docker/commit/76b7969: Runs update.sh
- https///github.com/nextcloud/docker/commit/3fd3a40: Runs update.sh
- https///github.com/nextcloud/docker/commit/13eb696: doc: fix link to OpCache server doc (https///github.com/nextcloud/docker/pull/1703)
axelsimon added a commit to axelsimon/docker-nextcloud that referenced this pull request Apr 12, 2022
In line with nextcloud/docker#1702 and to avoid the error message:
> The OPcache interned strings buffer is nearly full. To assure that repeating strings can be effectively cached, it is recommended to apply opcache.interned_strings_buffer to your PHP configuration with a value higher than 8.
ananace pushed a commit to ananace/docker-nextcloud that referenced this pull request May 10, 2024
* Increase (double) opcache string buffer size (debian)

This fixes nextcloud#1692

* Increase (double) opcache string buffer size (alpine)

This fixes nextcloud#1692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants