Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update general_troubleshooting.rst #12226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zenlord
Copy link

@zenlord zenlord commented Sep 24, 2024

Correcting the information in the note in section "Service Discovery" - it appears to not be true in all circumstances, so I added a nuance and a reference to a scenario in which it is not true

☑️ Resolves

  • Fix #…

🖼️ Screenshots

Correcting the information in the *note* in section "Service Discovery" - it appears to not be true in all circumstances, so I added a nuance and a reference to a scenario in which it is not true

Signed-off-by: Vincent <zenlord@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@susnux
Copy link
Contributor

susnux commented Nov 13, 2024

Thank you for the pull request!
I am not sure here as the docs say in vhost configurations the leading slash is always included:
https://httpd.apache.org/docs/current/mod/mod_rewrite.html#rewriterule

It sounds weird to me that Debian should patch their apache package to break with upstream behavior?
Maybe it is your RewriteBase?

@zenlord
Copy link
Author

zenlord commented Nov 13, 2024

Hi @susnux ,
I was not familiar with the official docs, but am I misreading the 5th bullet point under 'per-directory' settings? This looks like you would never need a forward slash at the start of your rewrite rules?

The removed prefix always ends with a slash, meaning the matching occurs against a string which never has a leading slash. Therefore, a Pattern with ^/ never matches in per-directory context.

Anyway, I'm not an expert, so if you believe this PR is not correct, don't feel bad about rejecting it :).

@susnux
Copy link
Contributor

susnux commented Nov 14, 2024

This looks like you would never need a forward slash at the start of your rewrite rules?

Only if in .htaccess or <Directory> context.

@zenlord
Copy link
Author

zenlord commented Nov 14, 2024

This looks like you would never need a forward slash at the start of your rewrite rules?

Only if in .htaccess or <Directory> context.

That is correct, but I also read:

Although rewrite rules are syntactically permitted in <Location> and <Files> sections (including their regular expression counterparts), this should never be necessary and is unsupported. A likely feature to break in these contexts is relative substitutions.

I did indeed place the Rewrite-block in a directory section, which explains why it is working for me, but at the same time renders it clear that the PR is not entirely correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants