Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove legacy code that caused errors #1260

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: Remove legacy code that caused errors #1260

merged 1 commit into from
Aug 7, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 17, 2024

The code was not used with 28+ anymore and removed in 29+ so we also need to remove for 28.

@nickvergessen nickvergessen removed their request for review June 19, 2024 09:29
@nickvergessen
Copy link
Member

Not familiar with this, so removing myself

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@Pytal
Copy link
Member

Pytal commented Jun 19, 2024

CI is related 🧐

@susnux susnux force-pushed the fix/legacy branch 3 times, most recently from 6853abf to 85f48db Compare June 22, 2024 14:38
@susnux
Copy link
Contributor Author

susnux commented Jun 22, 2024

CI is related 🧐

@Pytal should be fixed

@Pytal
Copy link
Member

Pytal commented Jun 25, 2024

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 1b5c4ee into stable28 Aug 7, 2024
38 checks passed
@susnux susnux deleted the fix/legacy branch August 7, 2024 13:47
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants