Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recommended app notifications #226

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Update recommended app notifications #226

merged 3 commits into from
Dec 18, 2019

Conversation

juliusknorr
Copy link
Member

Implements #225

image

@juliusknorr juliusknorr added this to the Nextcloud 18 milestone Dec 17, 2019
rullzer
rullzer approved these changes Dec 17, 2019
View reviewed changes
img/apps/social.svg Outdated Show resolved Hide resolved
@juliusknorr juliusknorr force-pushed the enh/225/notification-updates branch from fbcc1b1 to 55f4b03 Compare December 17, 2019 14:24
@jancborchardt
Copy link
Member

Awesome! Besides cutting the "Nextcloud" from "Nextcloud Social" just one thing: Can we have the order reversed? That is, so it shows up for people as in the issue:

  • Tasks
  • Deck
  • Notes
  • Social
  • Group folders

Thanks! :)

jancborchardt
jancborchardt requested changes Dec 17, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment, otherwise awesome! :)

@juliusknorr
Copy link
Member Author

juliusknorr commented Dec 18, 2019 •
edited
Loading

@jancborchardt I reordered the list as wished 😉

@juliusknorr
Update recommended app notifications
856bbd1 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Adjust order of recommended apps
75a0476 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Optimize images
cbac75d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the enh/225/notification-updates branch from c160083 to cbac75d Compare December 18, 2019 12:28
jancborchardt
jancborchardt approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 let’s get it in! :)

@rullzer rullzer merged commit a401c3f into master Dec 18, 2019
@rullzer rullzer deleted the enh/225/notification-updates branch December 18, 2019 13:44
@rullzer rullzer mentioned this pull request Dec 19, 2019
Merged
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
Nextcloud 18
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @jancborchardt @rullzer