Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextcloud.initLock to set NEXTCLOUD_INIT_LOCK #343

Closed
wants to merge 2 commits into from

Conversation

remram44
Copy link

@remram44 remram44 commented Jan 27, 2023

Pull Request

Description of the change

This allows setting NEXTCLOUD_INIT_LOCK, see nextcloud/docker#1760

Benefits

If running multiple replicas, this will avoid them walking over each other when upgrading.

Possible drawbacks

If an upgrade is aborted in progress, the lock file might be left behind. You will have to manually delete it before another upgrade can be attempted. This is an issue in the Docker image that I filed here: nextcloud/docker#1903

Applicable issues

Checklist

Signed-off-by: Remi Rampin <remi@rampin.org>
@provokateurin
Copy link
Member

So the docker image now uses flock, so it's safe to enable the init lock by default, right?

@remram44
Copy link
Author

NEXTCLOUD_INIT_LOCK was removed by nextcloud/docker@8aabc4b so this is no longer relevant.

@remram44 remram44 closed this Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants