htmlpurifier v4.18.0 is causing errors in the log

[Grotax]

Original issue: #2883

Downgrade: #2924

Issue at htmlpurifier ezyang/htmlpurifier#428

This needs some investigation why this version causes errors, maybe our configuration is no longer working?

[blizzz]

I tried to repro the issue:

1. composer require ezyang/htmlpurifier which pulls in 4.18
2. add a feed
3. force-run the background job
4. check logs
5. repeat steps 2-5 a couple of times

Should I encounter the problem?

Also possible: dependency hell, by getting in conflict with shipped versions in other apps. Using php-scoper to integrate it into news own namespace could be a way, if this really is the case.

[blizzz]

@FadeFx can you say whether my repro steps were reasonable? And do you recall which others apps were enabled at that time?

[FadeFx]

Actually @Grotax would be the better person to ask. I had only captured the error message and reported it.

[Grotax]

We probably ran in a conflict with the mail app, it also uses htmlpurifier. I just checked on my instance there it has 4.18 installed now so I guess using news with 4.18 would be fine as well but maybe we should try to prevent future conflicts.

@FadeFx did/do you also happen to have the mail app installed?

[blizzz]

We probably ran in a conflict with the mail app, it also uses htmlpurifier. I just checked on my instance there it has 4.18 installed now so I guess using news with 4.18 would be fine as well but maybe we should try to prevent future conflicts.

Best then indeed to go and pull in the dependencies to avoid such conflicts. Even if it is sort of aligned between apps, you cannot be sure that someone does not run a combination of different versions, shipping different things.

[FadeFx]

@FadeFx did/do you also happen to have the mail app installed?

Yes, mail app is installed.

[blizzz]

I can look into scoping the dependencies, but am without laptop the next week. Otherwise, this is what i did elsewhere in the past.

PHP 8.4 support required more adjustments though.

[Grotax]

Hey @blizzz yea that would be nice I currently don't have much time :)

[blizzz]

👍 Busy with baking cakes these weeks` nights 🫣