-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vue material icons #1816
Fix vue material icons #1816
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
67c9228
to
82ac3fb
Compare
809b906
to
95dccb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! The icons just disappeared on the bundles... AppNavigation falls from 50 KiB to 20 KiB 😅 Nice step! 🎉
Honestly i didn't check all the css in detail, but generally looks good to me...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
95dccb1
to
f5de77e
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing - but apart of that. 👍 🎉
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reducing the bundles size is great and necessary. Seems good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1816 (comment)
Co-authored-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@raimund-schluessler https://60672dfeacb72f0007de3ed6--nextcloud-vue-components.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to release v3.9.0 before merging
This screenshot is from the netlify docs. But you need to change the title of the last crumb to something longer. The default one is to short to trigger the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍
For all that were possible, I switched to the material design icons straight away.
For the others (like pure css without slots or our custom statuses), I moved back to a simple url-loader and a
theme--dark
selector.It will clean the already-too-complicated webpack config, as well as reducing the size of the final build. I took the liberty of fixing some blatant typos and changed a few docs.
The icons used are not 16px, because MaterialDesign ships 24px with margins.⚠️
So we're on 24px now
🖼️ Screenshots from this doc where everything is changed (Click to expand)