Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still push notifications of twofactor_nextcloud_notification when in DND #1354

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Still push notifications of twofactor_nextcloud_notification when in DND #1354

merged 2 commits into from
Nov 4, 2022

Conversation

nickvergessen
Copy link
Member

Fix #1353

@nickvergessen
Still push notifications of twofactor_nextcloud_notification when in DND
7a8a862 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Nov 4, 2022
@nickvergessen nickvergessen self-assigned this Nov 4, 2022
@nickvergessen
Copy link
Member Author

/backport to stable25

@nickvergessen
Copy link
Member Author

/backport to stable24

@nickvergessen
Copy link
Member Author

/backport to stable23

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 10066 was 9500 (+5.95%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
Test on Postgres14
4551cbc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 10066 was 9500 (+5.95%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 4b60d08 into master Nov 4, 2022
@nickvergessen nickvergessen deleted the bugfix/1353/still-push-2fa-login-attempts branch November 4, 2022 08:52
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@nickvergessen
Copy link
Member Author

/backport 7a8a862 to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 4, 2022
Merged
1 task
@nickvergessen
Copy link
Member Author

/backport 7a8a862 to stable24

@nickvergessen
Copy link
Member Author

/backport 7a8a862 to stable23

This was referenced Nov 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@Ivansss Ivansss Awaiting requested review from Ivansss

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: push 📲
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

Still push twofactor notifications even if DND is set
2 participants
@nickvergessen @rullzer