FaceCover: Lazy load faces files once face cover is visible in device viewport #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… viewport fixes #1411 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
added a commit
to nextcloud/recognize
that referenced
this pull request
Nov 4, 2022
see nextcloud/photos#1457 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
changed the title
…vice viewport Signed-off-by: Marcel Klehr <mklehr@gmx.net>
…w face Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
enh/lazy-load-faces
branch
from
ef5d31d to
a9fc306
Compare
artonge
approved these changes
Nov 7, 2022
|
/compile amend /js |
marcelklehr
changed the title
Signed-off-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
enh/lazy-load-faces
branch
from
4fc0239 to
937b921
Compare
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
|
The backport to stable25 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1411
This makes sure we don't initiate thousands of requests but only request the list of faces for the faces that are immediately visible in the viewport. It's not virtual scrolling, but it's something.
fixes #1423