Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Also sort by getlastmodified when searching for photos #2229

Merged
merged 2 commits into from
Jan 2, 2024
Merged

[stable28] Also sort by getlastmodified when searching for photos #2229

merged 2 commits into from
Jan 2, 2024

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #2226

@artonge @backportbot-nextcloud
Also sort by getlastmodified when searching for photos
0665cd4 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working javascript Javascript related ticket labels Jan 2, 2024
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 28.0.2 milestone Jan 2, 2024
@artonge
Copy link
Collaborator

artonge commented Jan 2, 2024

/compile /

@artonge artonge enabled auto-merge January 2, 2024 20:02
@nextcloud-command
chore(assets): Recompile assets
e21cd2d 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge merged commit 6f72a58 into stable28 Jan 2, 2024
23 checks passed
@artonge artonge deleted the backport/2226/stable28 branch January 2, 2024 20:16
@blizzz blizzz mentioned this pull request Jan 15, 2024
Merged
@smartbyte
Copy link

smartbyte commented Jan 19, 2024 •
edited
Loading

Sorry to re-open this case, but the sorting is still not correct in version 28.0.2 RC1 :-(
It now looks like the system is

  1. picking files that have an exif date,
  2. do an "order by"
  3. adding that to the empty list
  4. picking files with a "last-modified" date
  5. do an "order by"
  6. attaching it to the list.

What I would have needed:

  1. picking files that have an exif date
  2. picking files that have no exif date and use the last modified date
  3. "order by" the "merged" date
  4. and then attach it to the list

Would that be possible too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
bug Something isn't working javascript Javascript related ticket
Projects
None yet
Milestone
Nextcloud 28.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @smartbyte @nextcloud-command