Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] Various fix from 30 #2517

Merged
merged 10 commits into from
Jul 4, 2024
Merged

[stable29] Various fix from 30 #2517

merged 10 commits into from
Jul 4, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jul 4, 2024

Manual partial backport of #2514

artonge added 10 commits July 4, 2024 17:30
@artonge
feat: Display the upload button for empty albums
9a8bde2 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix: Center empty content in empty albums
aaaeed7 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix: Reinit the files in File.vue
66e2853 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
chore: Remove useless v-if in AlbumContent
c61d3f9 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix: Check if album is defined before accessing it in AlbumContent
556c2c4 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix: Declare photosLocationFolder as computed
ee22e10 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix: Make route name unique
e74c8c3 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
dix: Populate photosLocationFolder on init
e5121fb 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix: Limit upload picker custom css to header
659609f 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
chore: Compile assets
d9864e2 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Jul 4, 2024
@artonge artonge requested a review from nfebe July 4, 2024 15:41
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Jul 4, 2024
@artonge artonge added this to the Nextcloud 29.0.4 milestone Jul 4, 2024
nfebe
nfebe reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fewer commits?

@nfebe
Copy link
Contributor

nfebe commented Jul 4, 2024

Ah I see the partial, what are we leaving out?

@artonge artonge mentioned this pull request Jul 4, 2024
Merged
@artonge
Copy link
Collaborator Author

artonge commented Jul 4, 2024 •
edited
Loading

Ah I see the partial, what are we leaving out?

Unneeded or invisible fixes:

  • chore: Fix typo in collection.js - not visible
  • chore: Use NcSelect label - no error in the browser console
  • fix: Don't proceed with album creation if it fails - 29 does not need the extra error handling
  • chore: Explicitly require @nc/router - only to make linter happy, so superfluous
  • fix: Specify a source for the tmp local album - no error in the browser console

@artonge artonge merged commit da009af into stable29 Jul 4, 2024
45 checks passed
@artonge artonge deleted the artonge/backport/2514/stable29 branch July 4, 2024 16:09
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Milestone
Nextcloud 29.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @nfebe