fix(files_trashbin): check if there is enough space before restoring

Signed-off-by: Kent Delante <kent.delante@proton.me>

Author: leftybournes

apps/files_trashbin/lib/Sabre/TrashbinPlugin.php

@@ -8,6 +8,7 @@
  */
 namespace OCA\Files_Trashbin\Sabre;
 
+use OC\Files\Filesystem;
 use OCA\DAV\Connector\Sabre\FilesPlugin;
 use OCA\Files_Trashbin\Trash\ITrashItem;
 use OCP\IPreview;
@@ -40,6 +41,7 @@ public function initialize(Server $server) {
 
 		$this->server->on('propFind', [$this, 'propFind']);
 		$this->server->on('afterMethod:GET', [$this,'httpGet']);
+		$this->server->on('beforeMove', [$this, 'beforeMove']);
 	}
 
 
@@ -129,4 +131,41 @@ public function httpGet(RequestInterface $request, ResponseInterface $response):
 			$response->addHeader('Content-Disposition', 'attachment; filename="' . $node->getFilename() . '"');
 		}
 	}
+
+	/**
+	 * Check if a user has available space before attempting to
+	 * restore from trashbin unless they have unlimited quota.
+	 *
+	 * @param string $sourcePath
+	 * @param string $destinationPath
+	 * @return bool
+	 */
+	public function beforeMove(string $sourcePath, string $destinationPath): bool {
+		try {
+			$node = $this->server->tree->getNodeForPath($sourcePath);
+			$destinationNode = $this->server->tree->getNodeForPath(dirname($destinationPath));
+		} catch (\Exception $e) {
+			return true;
+		}
+
+		// Since we're concerned with restoring from trash, the source must
+		// come from the trashbin and go into the restore folder. Check if that
+		// is the operation being attempted before checking for quota and free space.
+		if (!$node instanceof ITrash || !$destinationNode instanceof RestoreFolder) {
+			return true;
+		}
+
+		$fileInfo = $node->getFileInfo();
+		if (!$fileInfo instanceof ITrashItem) {
+			return true;
+		}
+		$freeSpace = Filesystem::free_space($fileInfo->getOriginalLocation());
+		$filesize = $fileInfo->getSize();
+		if ($freeSpace >= 0 && $freeSpace < $filesize) {
+			$this->server->httpResponse->setStatus(507);
+			return false;
+		}
+
+		return true;
+	}
 }

apps/files_trashbin/src/files_actions/restoreAction.ts

@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 import { getCurrentUser } from '@nextcloud/auth'
+import { showError } from '@nextcloud/dialogs'
 import { emit } from '@nextcloud/event-bus'
 import { Permission, Node, View, FileAction } from '@nextcloud/files'
 import { t } from '@nextcloud/l10n'
@@ -52,6 +53,9 @@ export const restoreAction = new FileAction({
 			emit('files:node:deleted', node)
 			return true
 		} catch (error) {
+			if (error.response?.status === 507) {
+				showError(t('files_trashbin', 'Not enough free space to restore the file/folder'))
+			}
 			logger.error('Failed to restore node', { error, node })
 			return false
 		}