Skip to content

Commit

Permalink
Merge pull request #45881 from nextcloud/revert-45870-backport/45867/…
Browse files Browse the repository at this point in the history
…stable28

Revert "[stable28] fix(comments): Use proper icon components instead …
  • Loading branch information
blizzz authored Jun 17, 2024
2 parents 5ba6f3e + 28acd82 commit 323162f
Show file tree
Hide file tree
Showing 12 changed files with 25 additions and 38 deletions.
36 changes: 12 additions & 24 deletions apps/comments/src/components/Comment.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,27 +40,22 @@
show if we have a message id and current user is author -->
<NcActions v-if="isOwnComment && id && !loading" class="comment__actions">
<template v-if="!editing">
<NcActionButton close-after-click
<NcActionButton :close-after-click="true"
icon="icon-rename"
@click="onEdit">
<template #icon>
<IconEdit :size="20" />
</template>
{{ t('comments', 'Edit comment') }}
</NcActionButton>
<NcActionSeparator />
<NcActionButton close-after-click
<NcActionButton :close-after-click="true"
icon="icon-delete"
@click="onDeleteWithUndo">
<template #icon>
<IconDelete :size="20" />
</template>
{{ t('comments', 'Delete comment') }}
</NcActionButton>
</template>

<NcActionButton v-else @click="onEditCancel">
<template #icon>
<IconClose :size="20" />
</template>
<NcActionButton v-else
icon="icon-close"
@click="onEditCancel">
{{ t('comments', 'Cancel edit') }}
</NcActionButton>
</NcActions>
Expand Down Expand Up @@ -92,8 +87,8 @@
:disabled="isEmptyMessage"
@click="onSubmit">
<template #icon>
<NcLoadingIcon v-if="loading" />
<IconArrowRight v-else :size="20" />
<span v-if="loading" class="icon-loading-small" />
<ArrowRight v-else :size="20" />
</template>
</NcButton>
</div>
Expand Down Expand Up @@ -127,11 +122,7 @@ import NcActionSeparator from '@nextcloud/vue/dist/Components/NcActionSeparator.
import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar.js'
import NcButton from '@nextcloud/vue/dist/Components/NcButton.js'
import RichEditorMixin from '@nextcloud/vue/dist/Mixins/richEditor.js'

import IconArrowRight from 'vue-material-design-icons/ArrowRight.vue'
import IconClose from 'vue-material-design-icons/Close.vue'
import IconDelete from 'vue-material-design-icons/Delete.vue'
import IconEdit from 'vue-material-design-icons/Pencil.vue'
import ArrowRight from 'vue-material-design-icons/ArrowRight.vue'

import Moment from './Moment.vue'
import CommentMixin from '../mixins/CommentMixin.js'
Expand All @@ -143,16 +134,13 @@ export default {
name: 'Comment',

components: {
IconArrowRight,
IconClose,
IconDelete,
IconEdit,
Moment,
NcActionButton,
NcActions,
NcActionSeparator,
ArrowRight,
NcAvatar,
NcButton,
Moment,
NcRichContenteditable,
},
mixins: [RichEditorMixin, CommentMixin],
Expand Down
3 changes: 1 addition & 2 deletions apps/comments/src/views/ActivityCommentEntry.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
</template>

<script lang="ts">
import type { PropType } from 'vue'
import { translate as t } from '@nextcloud/l10n'

import Comment from '../components/Comment.vue'
Expand All @@ -54,7 +53,7 @@ export default {
required: true,
},
reloadCallback: {
type: Function as PropType<() => void>,
type: Function,
required: true,
},
},
Expand Down
2 changes: 0 additions & 2 deletions dist/1241-1241.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/1241-1241.js.map

This file was deleted.

2 changes: 2 additions & 0 deletions dist/5632-5632.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 323162f

Please sign in to comment.