Skip to content

Commit

Permalink
enh(breadcrumbs): removed unnecessary aria label
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
  • Loading branch information
emoral435 committed Dec 26, 2023
1 parent af6f1cd commit 576bb23
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 8 deletions.
16 changes: 11 additions & 5 deletions apps/files/src/components/BreadCrumbs.vue
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
<template>
<NcBreadcrumbs data-cy-files-content-breadcrumbs>
<NcBreadcrumbs
data-cy-files-content-breadcrumbs
:aria-label="t('files', 'Current directory path')">
<!-- Current path sections -->
<NcBreadcrumb v-for="(section, index) in sections"
:key="section.dir"
:aria-label="ariaLabel(section)"
:title="ariaLabel(section)"
v-bind="section"
dir="auto"
:to="section.to"
:title="titleForSection(section)"
@click.native="onClick(section.to)">
<template v-if="index === 0" #icon>
<Home :size="20" />
<Home :size="20"/>
</template>
</NcBreadcrumb>

Expand All @@ -20,6 +23,7 @@
</template>

<script>
import { translate as t} from '@nextcloud/l10n'
import { basename } from 'path'
import Home from 'vue-material-design-icons/Home.vue'
import NcBreadcrumb from '@nextcloud/vue/dist/Components/NcBreadcrumb.js'
Expand Down Expand Up @@ -104,12 +108,14 @@ export default Vue.extend({
}
},
ariaLabel(section) {
titleForSection(section) {
if (section?.to?.query?.dir === this.$route.query.dir) {
return t('files', 'Reload current directory')
}
return t('files', 'Go to the "{dir}" directory', section)
},
t,
},
})
</script>
Expand Down
4 changes: 2 additions & 2 deletions dist/files-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map

Large diffs are not rendered by default.

0 comments on commit 576bb23

Please sign in to comment.