Use aria-expanded correctly on toggle user actions

The aria-expanded attribute was added on the expandable item rather Than the button that triggers the expand. Resolves : #37137 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nextcloud · May 17, 2023 · dc16821 · dc16821
1 parent 85df0f6
commit dc16821
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 10 deletions.
diff --git a/apps/settings/src/components/UserList/UserRow.vue b/apps/settings/src/components/UserList/UserRow.vue
@@ -250,6 +250,8 @@
 				</NcActions>
 				<div v-click-outside="hideMenu" class="userPopoverMenuWrapper">
 					<button class="icon-more"
+						:aria-expanded="openedMenu"
+						:aria-label="t('settings', 'Toggle user actions menu')"
 						@click.prevent="toggleMenu" />
 					<div :class="{ 'open': openedMenu }" class="popovermenu">
 						<NcPopoverMenu :menu="userActions" />

diff --git a/apps/settings/src/components/UserList/UserRowSimple.vue b/apps/settings/src/components/UserList/UserRowSimple.vue
@@ -69,9 +69,10 @@
 				<div class="userPopoverMenuWrapper">
 					<button v-click-outside="hideMenu"
 						class="icon-more"
+						:aria-expanded="openedMenu"
 						:aria-label="t('settings', 'Toggle user actions menu')"
 						@click.prevent="toggleMenu" />
-					<div class="popovermenu" :class="{ 'open': openedMenu }" :aria-expanded="openedMenu">
+					<div class="popovermenu" :class="{ 'open': openedMenu }">
 						<NcPopoverMenu :menu="userActions" />
 					</div>
 				</div>

diff --git a/dist/core-common.js b/dist/core-common.js
diff --git a/dist/core-common.js.map b/dist/core-common.js.map
diff --git a/dist/settings-users-8351.js b/dist/settings-users-8351.js
diff --git a/dist/settings-users-8351.js.map b/dist/settings-users-8351.js.map
diff --git a/dist/settings-vue-settings-apps-users-management.js b/dist/settings-vue-settings-apps-users-management.js
diff --git a/dist/settings-vue-settings-apps-users-management.js.map b/dist/settings-vue-settings-apps-users-management.js.map