From 0d987dd2a069984dd71d0b35c4880e66e782a97a Mon Sep 17 00:00:00 2001 From: Carl Schwan Date: Fri, 23 Jul 2021 14:32:54 +0200 Subject: [PATCH] Fix tests in files_versions Signed-off-by: Carl Schwan --- .../tests/Controller/PreviewControllerTest.php | 6 ------ apps/files_versions/tests/ExpirationTest.php | 4 +++- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/apps/files_versions/tests/Controller/PreviewControllerTest.php b/apps/files_versions/tests/Controller/PreviewControllerTest.php index 51ef45af88106..64a060e310809 100644 --- a/apps/files_versions/tests/Controller/PreviewControllerTest.php +++ b/apps/files_versions/tests/Controller/PreviewControllerTest.php @@ -73,7 +73,6 @@ protected function setUp(): void { $user->expects($this->any()) ->method('getUID') ->willReturn($this->userId); - $this->mimeTypeDetector = $this->createMock(IMimeTypeDetector::class); $this->previewManager = $this->createMock(IPreview::class); $this->userSession = $this->createMock(IUserSession::class); $this->userSession->expects($this->any()) @@ -86,7 +85,6 @@ protected function setUp(): void { $this->createMock(IRequest::class), $this->rootFolder, $this->userSession, - $this->mimeTypeDetector, $this->versionManager, $this->previewManager ); @@ -170,10 +168,6 @@ public function testVersionNotFound() { ->with('file') ->willReturn($sourceFile); - $this->mimeTypeDetector->method('detectPath') - ->with($this->equalTo('file')) - ->willReturn('myMime'); - $this->versionManager->method('getVersionFile') ->willThrowException(new NotFoundException()); diff --git a/apps/files_versions/tests/ExpirationTest.php b/apps/files_versions/tests/ExpirationTest.php index fdfba49c2e235..228d1d6830c6d 100644 --- a/apps/files_versions/tests/ExpirationTest.php +++ b/apps/files_versions/tests/ExpirationTest.php @@ -29,6 +29,7 @@ use OCP\AppFramework\Utility\ITimeFactory; use OCP\IConfig; use PHPUnit\Framework\MockObject\MockObject; +use Psr\Log\LoggerInterface; class ExpirationTest extends \Test\TestCase { public const SECONDS_PER_DAY = 86400; //60*60*24 @@ -109,8 +110,9 @@ public function expirationData() { public function testExpiration($retentionObligation, $timeNow, $timestamp, $quotaExceeded, $expectedResult) { $mockedConfig = $this->getMockedConfig($retentionObligation); $mockedTimeFactory = $this->getMockedTimeFactory($timeNow); + $mockedLogger = $this->createMock(LoggerInterface::class); - $expiration = new Expiration($mockedConfig, $mockedTimeFactory); + $expiration = new Expiration($mockedConfig, $mockedTimeFactory, $mockedLogger); $actualResult = $expiration->isExpired($timestamp, $quotaExceeded); $this->assertEquals($expectedResult, $actualResult);