-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrity fails if mime type list is extended #10411
Comments
This comment has been minimized.
This comment has been minimized.
I'm a bit drawn a part, because it is actually necessary and good information that the file is "non-default". But since this spams a notification all the time you visit the web UI 🙀 |
I would say, that this is less critical now since #12418 is in. |
The code change needs to look similar to this (and also is then placed there): server/lib/private/IntegrityCheck/Checker.php Lines 345 to 356 in c6a69ba
This is how a similar way looked before for the modified c6a69ba#diff-8c88c803f1798e69a75cd73cbaba2a12L183 Tests can be found in here: server/tests/lib/IntegrityCheck/CheckerTest.php Lines 723 to 762 in c6a69ba
Steps:
cc @xh3n1 |
Still having this issue on 21.0.3 |
I got this issue aswell after manually running the
My admin setting/overview Security & setup warnings are timing out with "Error occurred while checking server setup", don't know if that is related. Here are some logs that seem to have to do with integrity checking. They might have come from me running
|
The problem still exists on version 23.0.0, although I managed to do a workaround:
|
With 23.0.2 i got the same error. if there's a occ command to update this list and apps can extend it, this file should be excluded from integrity check. The header of that file mimetypelist.js /**
* This file is automatically generated
* DO NOT EDIT MANUALLY!
*
* You can update the list of MimeType Aliases in config/mimetypealiases.json
* The list of files is fetched from core/img/filetypes
* To regenerate this file run ./occ maintenance:mimetype:update-js
*/ The difference in my instance:
113c113,117
< "application/vnd.xmind.workbook": "mindmap"
---
> "application/vnd.xmind.workbook": "mindmap",
> "image/targa": "image/tga",
> "": "x-office/document",
> "application/vnd.openxmlformats-officedocument.wordprocessingml.document.docxf": "x-office/document",
> "application/vnd.openxmlformats-officedocument.wordprocessingml.document.oform": "x-office/document" This issue is present since at least NC 15! @skjnldsv Please reopen |
occ maintenance:mimetype:update-js
@nickvergessen @rullzer Ideas how to prevent this? Exclude the file from the check once we see that there are mimetypes added?
The text was updated successfully, but these errors were encountered: