Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove LDAP::hasPagedResultSupport() as it is always present in supported PHP versions #10923

Closed
blizzz opened this issue Aug 29, 2018 · 1 comment
Closed

remove LDAP::hasPagedResultSupport() as it is always present in supported PHP versions #10923

blizzz opened this issue Aug 29, 2018 · 1 comment
Assignees
@blizzz
Labels
feature: ldap technical debt
Milestone
Nextcloud 15

Comments

@blizzz
Copy link
Member

blizzz commented Aug 29, 2018

Remove check for presence of ldap_control_paged_result and ldap_control_paged_result_response (LDAP::hasPagedResultSupport) since they are present in any supported PHP version.
@blizzz blizzz added this to the Nextcloud 15 milestone Aug 29, 2018
@nextcloud-bot

This comment has been minimized.

Sign in to view
blizzz added a commit that referenced this issue Oct 25, 2018
@blizzz
functions that were checked for are present since PHP 5.4, supported …
2048872 
…is >=/

* so the check from older days is really not necessary anymore
* resolves #10923

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz mentioned this issue Oct 25, 2018
Merged
@blizzz blizzz self-assigned this Oct 25, 2018
weeman1337 pushed a commit that referenced this issue Oct 28, 2018
@blizzz @weeman1337
functions that were checked for are present since PHP 5.4, supported …
15b7103 
…is >=/

* so the check from older days is really not necessary anymore
* resolves #10923

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blizzz blizzz

Labels
feature: ldap technical debt
Projects
None yet
Milestone
Nextcloud 15
Development

No branches or pull requests
2 participants
@blizzz @nextcloud-bot